diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-06-07 11:36:39 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-14 15:40:55 -0700 |
| commit | 3cdd5a286e8f758182f2bc90bdc56c267b253245 (patch) | |
| tree | 78704966733c1e2d43edad66f95dca4adf72d157 /tools/v8_gypfiles/v8.gyp | |
| parent | 30f285da314dc5c9fa7457784d948bf5ddfab361 (diff) | |
| download | android-node-v8-3cdd5a286e8f758182f2bc90bdc56c267b253245.tar.gz android-node-v8-3cdd5a286e8f758182f2bc90bdc56c267b253245.tar.bz2 android-node-v8-3cdd5a286e8f758182f2bc90bdc56c267b253245.zip | |
build: unbreak --with-intl=system-icu build
Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.
Fixes: https://github.com/nodejs/node/issues/28052
PR-URL: https://github.com/nodejs/node/pull/28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'tools/v8_gypfiles/v8.gyp')
| -rw-r--r-- | tools/v8_gypfiles/v8.gyp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index 58aff1409e..46fb49295f 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -393,13 +393,6 @@ '<(icu_gyp_path):icui18n', '<(icu_gyp_path):icuuc', ], - 'direct_dependent_settings': { - 'include_dirs': [ - '<(icu_path)/source/common', - '<(icu_path)/source/i18n', - '<(icu_path)/source/tools/toolutil', - ], - }, }], ], }, # v8_maybe_icu |