diff options
author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-08-29 21:57:09 +0530 |
---|---|---|
committer | Ujjwal Sharma <usharma1998@gmail.com> | 2019-09-06 02:23:49 +0530 |
commit | 2882ce911df821895c70d2ee99a88a4554fa3221 (patch) | |
tree | 8a4ebd3a49c4842678b1261f76ddfcf47af1ca6d /tools/v8_gypfiles/broken | |
parent | 4e5bb250d8c256dd32af3b2a7fd99197a56c21d6 (diff) | |
download | android-node-v8-2882ce911df821895c70d2ee99a88a4554fa3221.tar.gz android-node-v8-2882ce911df821895c70d2ee99a88a4554fa3221.tar.bz2 android-node-v8-2882ce911df821895c70d2ee99a88a4554fa3221.zip |
tools: delete v8_external_snapshot.gypi
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.
Refs: https://github.com/nodejs/node/pull/29363#issuecomment-526103293
Fixes: https://github.com/nodejs/node/issues/28964
PR-URL: https://github.com/nodejs/node/pull/29369
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'tools/v8_gypfiles/broken')
-rw-r--r-- | tools/v8_gypfiles/broken/standalone.gypi | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/v8_gypfiles/broken/standalone.gypi b/tools/v8_gypfiles/broken/standalone.gypi index f01b5975fc..f010679434 100644 --- a/tools/v8_gypfiles/broken/standalone.gypi +++ b/tools/v8_gypfiles/broken/standalone.gypi @@ -227,12 +227,6 @@ # speeds. 'v8_optimized_debug%': 0, - # Use external files for startup data blobs: - # the JS builtins sources and the start snapshot. - # Embedders that don't use standalone.gypi will need to add - # their own default value. - 'v8_use_external_startup_data%': 1, - # Relative path to icu.gyp from this file. 'icu_gyp_path': '../third_party/icu/icu.gyp', |