diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-04-06 10:41:29 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-04-11 21:03:39 -0700 |
| commit | 33d4f828ee2c8d93b593649af38225a9e864efa7 (patch) | |
| tree | 9f513e90b86b0c1b745c9e73f23993786331a45c /tools/test.py | |
| parent | cf34c2c79e73ad6d3eca5ba13a5921077d9083d3 (diff) | |
| download | android-node-v8-33d4f828ee2c8d93b593649af38225a9e864efa7.tar.gz android-node-v8-33d4f828ee2c8d93b593649af38225a9e864efa7.tar.bz2 android-node-v8-33d4f828ee2c8d93b593649af38225a9e864efa7.zip | |
tools: include exit code in test failures
Include the exit code in test failures. This will give us more
information during the currently-puzzling failures that provide no
information in CI such as:
```
03:10:10 not ok 563 parallel/test-fs-truncate
03:10:10 ---
03:10:10 duration_ms: 1.119
03:10:10 severity: fail
03:10:10 stack: |-
03:10:10 ...
```
PR-URL: https://github.com/nodejs/node/pull/19855
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'tools/test.py')
| -rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index 230774b256..3b63780170 100755 --- a/tools/test.py +++ b/tools/test.py @@ -284,7 +284,7 @@ class TapProgressIndicator(SimpleProgressIndicator): if output.UnexpectedOutput(): status_line = 'not ok %i %s' % (self._done, command) self.severity = 'fail' - self.traceback = output.output.stdout + output.output.stderr + self.traceback = "exit code: " + output.output.exit_code + "\n" + output.output.stdout + output.output.stderr if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE: status_line = status_line + ' # TODO : Fix flaky test' |