diff options
| author | Julien Gilli <julien.gilli@joyent.com> | 2017-02-03 19:57:25 +0000 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2017-02-04 06:15:25 +0100 |
| commit | 23cda7d9de14883a43b159cc922f66f818c6ccf7 (patch) | |
| tree | 62c15433e40cef302752e825646d4735924ba748 /tools/test.py | |
| parent | 5e52a9ac0936e503d7752ab9afb597e381a824db (diff) | |
| download | android-node-v8-23cda7d9de14883a43b159cc922f66f818c6ccf7.tar.gz android-node-v8-23cda7d9de14883a43b159cc922f66f818c6ccf7.tar.bz2 android-node-v8-23cda7d9de14883a43b159cc922f66f818c6ccf7.zip | |
test: fix test.py command line options processing
https://github.com/nodejs/node/pull/11086 had introduced a regression
that broke command line options processing for tools/test.py.
Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:
```
$ python tools/test.py --abort-on-timeout path/to/some-test
```
all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.
This change fixes this regression.
Refs: https://github.com/nodejs/node/pull/11086
PR-URL: https://github.com/nodejs/node/pull/11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'tools/test.py')
| -rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index c900b1a83a..f46b13fa30 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1399,7 +1399,7 @@ def BuildOptions(): default=1, type="int") result.add_option('--abort-on-timeout', help='Send SIGABRT instead of SIGTERM to kill processes that time out', - default=False, dest="abort_on_timeout") + default=False, action="store_true", dest="abort_on_timeout") return result |