summaryrefslogtreecommitdiff
path: root/tools/js2c_macros/dcheck_macros.py
diff options
context:
space:
mode:
authorbcoe <bencoe@google.com>2019-12-01 12:55:54 -0800
committerBenjamin Coe <bencoe@google.com>2019-12-05 15:46:55 -0800
commitbfd9de63c9521a7d26ab27f87de386434bdf649b (patch)
tree3c8c2ee89bc3a96f45cfbd0d2941c4caf6432ae7 /tools/js2c_macros/dcheck_macros.py
parent651c43082698ba3bfa4f2417944719f771c09f04 (diff)
downloadandroid-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.tar.gz
android-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.tar.bz2
android-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.zip
build: remove (almost) unused macros/constants
Macros, like CHECK, cause issues for tracking coverage because they modify the source before it's placed in V8. Upon investigation it seemed that we only used this functionality in two places: internal/vm/module.js, and internal/async_hooks.js (in comments). Given this, it seemed to make more sense to move CHECK to JavaScript, and retire a mostly unused build step. PR-URL: https://github.com/nodejs/node/pull/30755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'tools/js2c_macros/dcheck_macros.py')
-rw-r--r--tools/js2c_macros/dcheck_macros.py9
1 files changed, 0 insertions, 9 deletions
diff --git a/tools/js2c_macros/dcheck_macros.py b/tools/js2c_macros/dcheck_macros.py
deleted file mode 100644
index f22c08598f..0000000000
--- a/tools/js2c_macros/dcheck_macros.py
+++ /dev/null
@@ -1,9 +0,0 @@
-# flake8: noqa
-
-macro DCHECK(x) = do { if (!(x)) (process._rawDebug("DCHECK: x == true"), process.abort()) } while (0);
-macro DCHECK_EQ(a, b) = DCHECK((a) === (b));
-macro DCHECK_GE(a, b) = DCHECK((a) >= (b));
-macro DCHECK_GT(a, b) = DCHECK((a) > (b));
-macro DCHECK_LE(a, b) = DCHECK((a) <= (b));
-macro DCHECK_LT(a, b) = DCHECK((a) < (b));
-macro DCHECK_NE(a, b) = DCHECK((a) !== (b));