diff options
| author | Steven R. Loomis <srloomis@us.ibm.com> | 2018-10-03 13:39:14 -0700 |
|---|---|---|
| committer | Steven R. Loomis <srloomis@us.ibm.com> | 2018-10-04 14:27:07 -0700 |
| commit | a4ffa0cb948d813ad77998c1d5c60a8e5dc52959 (patch) | |
| tree | 473663ee3c88c9b2e0e311bd1608b9a5ae703acd /tools/icu | |
| parent | 3d2124505eae95b72158a14c8f99373ca3e94e5a (diff) | |
| download | android-node-v8-a4ffa0cb948d813ad77998c1d5c60a8e5dc52959.tar.gz android-node-v8-a4ffa0cb948d813ad77998c1d5c60a8e5dc52959.tar.bz2 android-node-v8-a4ffa0cb948d813ad77998c1d5c60a8e5dc52959.zip | |
tools: fix ICU shrinker and docs
- tools: path to ICU datafile moved
- docs: configure is now configure.py
Fixes: https://github.com/nodejs/node/issues/23245
PR-URL: https://github.com/nodejs/node/pull/23266
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'tools/icu')
| -rw-r--r-- | tools/icu/README.md | 4 | ||||
| -rw-r--r-- | tools/icu/shrink-icu-src.py | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/tools/icu/README.md b/tools/icu/README.md index 223990bc45..01c1227931 100644 --- a/tools/icu/README.md +++ b/tools/icu/README.md @@ -92,7 +92,7 @@ make clean tools/license-builder.sh ``` -- Now, fix the default URL for the `full-icu` build in `/configure`, in +- Now, fix the default URL for the `full-icu` build in `/configure.py`, in the `configure_intl()` function. It should match the ICU URL used in the first step. When this is done, the following should build with full ICU. @@ -104,7 +104,7 @@ make make test-ci ``` -- commit the change to `configure` along with the updated `LICENSE` file. +- commit the change to `configure.py` along with the updated `LICENSE` file. - Note: To simplify review, I often will “pre-land” this patch, meaning that I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch diff --git a/tools/icu/shrink-icu-src.py b/tools/icu/shrink-icu-src.py index 63080603ad..e182435424 100644 --- a/tools/icu/shrink-icu-src.py +++ b/tools/icu/shrink-icu-src.py @@ -22,7 +22,7 @@ parser.add_option('--icu-src', parser.add_option('--icutmp', action='store', dest='icutmp', - default='out/Release/gen/icutmp', + default='out/Release/obj/gen/icutmp', help='path to icutmp dir.') |