diff options
| author | Steven R. Loomis <srloomis@us.ibm.com> | 2018-03-05 12:51:56 -0800 |
|---|---|---|
| committer | Steven R. Loomis <srloomis@us.ibm.com> | 2018-03-28 07:56:11 -0700 |
| commit | 4de78219711dcfdc24290520b20dce1fff01e164 (patch) | |
| tree | 6454569c1bed3f68d050b4ab339ac846781b9a8f /tools/icu | |
| parent | 5d387e9403bc67604b5556538fcddc52857638a6 (diff) | |
| download | android-node-v8-4de78219711dcfdc24290520b20dce1fff01e164.tar.gz android-node-v8-4de78219711dcfdc24290520b20dce1fff01e164.tar.bz2 android-node-v8-4de78219711dcfdc24290520b20dce1fff01e164.zip | |
deps: turn in std::string for ICU
- node and v8 did not call into std::string previously,
so that access was shut off.
- this fixes compilation for ICU 58.2 (backlevel) but may
be expressed in other versions also.
Fixes: https://github.com/nodejs/node/issues/19151
PR-URL: https://github.com/nodejs/node/pull/19624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Diffstat (limited to 'tools/icu')
| -rw-r--r-- | tools/icu/icu-generic.gyp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp index 8f29369255..a50f12d794 100644 --- a/tools/icu/icu-generic.gyp +++ b/tools/icu/icu-generic.gyp @@ -35,9 +35,7 @@ 'UCONFIG_NO_REGULAR_EXPRESSIONS=1', 'U_ENABLE_DYLOAD=0', 'U_STATIC_IMPLEMENTATION=1', - # Don't need std::string in API. - # Also, problematic: <http://bugs.icu-project.org/trac/ticket/11333> - 'U_HAVE_STD_STRING=0', + 'U_HAVE_STD_STRING=1', # TODO(srl295): reenable following pending # https://code.google.com/p/v8/issues/detail?id=3345 # (saves some space) |