diff options
| author | Matteo Collina <hello@matteocollina.com> | 2019-07-24 15:56:13 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-07-26 21:58:09 -0700 |
| commit | 147b9d9792fe5772b554f4be77305805f361a42d (patch) | |
| tree | 7cd4d56cc063c8efcda2a7cd57778fd68eb3d75e /tools/gyp | |
| parent | db1c4a7592a896053a8f791d7cc38a6de5c4a059 (diff) | |
| download | android-node-v8-147b9d9792fe5772b554f4be77305805f361a42d.tar.gz android-node-v8-147b9d9792fe5772b554f4be77305805f361a42d.tar.bz2 android-node-v8-147b9d9792fe5772b554f4be77305805f361a42d.zip | |
stream: resolve perf regression introduced by V8 7.3
This commit contains two fixes:
1. use instanceof instead of Object.getPrototypeOf, as checking an
object prototype with Object.getPrototypeOf is slower
than an instanceof check.
2. avoid parseInt(undefined, 10) to get NaN as it regressed.
PR-URL: https://github.com/nodejs/node/pull/28842
Fixes: https://github.com/nodejs/node/issues/28586
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'tools/gyp')
0 files changed, 0 insertions, 0 deletions