summaryrefslogtreecommitdiff
path: root/tools/gyp/PRESUBMIT.py
diff options
context:
space:
mode:
authorShigeki Ohtsu <ohtsu@iij.ad.jp>2015-03-30 14:33:17 +0900
committerShigeki Ohtsu <ohtsu@iij.ad.jp>2015-04-04 11:01:26 +0900
commit21f4fb62157567eb6e1eac08927d832c7b5b89dd (patch)
treea0f9f81df66f9ba9d2a925c6ce0d15954db57ffa /tools/gyp/PRESUBMIT.py
parentefadffe8616b895cd67fd270eadbd241d1069a47 (diff)
downloadandroid-node-v8-21f4fb62157567eb6e1eac08927d832c7b5b89dd.tar.gz
android-node-v8-21f4fb62157567eb6e1eac08927d832c7b5b89dd.tar.bz2
android-node-v8-21f4fb62157567eb6e1eac08927d832c7b5b89dd.zip
deps: update gyp to e1c8fcf7
PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'tools/gyp/PRESUBMIT.py')
-rw-r--r--tools/gyp/PRESUBMIT.py27
1 files changed, 23 insertions, 4 deletions
diff --git a/tools/gyp/PRESUBMIT.py b/tools/gyp/PRESUBMIT.py
index 9c474eb2b1..abec27b3e3 100644
--- a/tools/gyp/PRESUBMIT.py
+++ b/tools/gyp/PRESUBMIT.py
@@ -16,8 +16,6 @@ PYLINT_BLACKLIST = [
'test/lib/TestCmd.py',
'test/lib/TestCommon.py',
'test/lib/TestGyp.py',
- # Needs style fix.
- 'pylib/gyp/generator/xcode.py',
]
@@ -25,6 +23,10 @@ PYLINT_DISABLED_WARNINGS = [
# TODO: fix me.
# Many tests include modules they don't use.
'W0611',
+ # Possible unbalanced tuple unpacking with sequence.
+ 'W0632',
+ # Attempting to unpack a non-sequence.
+ 'W0633',
# Include order doesn't properly include local files?
'F0401',
# Some use of built-in names.
@@ -40,6 +42,10 @@ PYLINT_DISABLED_WARNINGS = [
'W0613',
# String has no effect (docstring in wrong place).
'W0105',
+ # map/filter on lambda could be replaced by comprehension.
+ 'W0110',
+ # Use of eval.
+ 'W0123',
# Comma not followed by space.
'C0324',
# Access to a protected member.
@@ -56,6 +62,8 @@ PYLINT_DISABLED_WARNINGS = [
'E1101',
# Dangerous default {}.
'W0102',
+ # Cyclic import.
+ 'R0401',
# Others, too many to sort.
'W0201', 'W0232', 'E1103', 'W0621', 'W0108', 'W0223', 'W0231',
'R0201', 'E0101', 'C0321',
@@ -116,5 +124,16 @@ def CheckChangeOnCommit(input_api, output_api):
return report
-def GetPreferredTrySlaves():
- return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac', 'gyp-android']
+TRYBOTS = [
+ 'gyp-win32',
+ 'gyp-win64',
+ 'gyp-linux',
+ 'gyp-mac',
+ 'gyp-android'
+]
+
+
+def GetPreferredTryMasters(_, change):
+ return {
+ 'tryserver.nacl': { t: set(['defaulttests']) for t in TRYBOTS },
+ }