diff options
author | cjihrig <cjihrig@gmail.com> | 2019-05-15 15:29:56 -0400 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-05-17 20:56:26 -0700 |
commit | af83b7963fdffab9a4d9ca9893de517f7213efa8 (patch) | |
tree | 4f974008b199bc79602624bd61a4147b49aaedec /tools/eslint-rules/require-common-first.js | |
parent | abe82110b78a54a504a104c2da97cbcc7e344e9f (diff) | |
download | android-node-v8-af83b7963fdffab9a4d9ca9893de517f7213efa8.tar.gz android-node-v8-af83b7963fdffab9a4d9ca9893de517f7213efa8.tar.bz2 android-node-v8-af83b7963fdffab9a4d9ca9893de517f7213efa8.zip |
tools: decrease code duplication for isString() in lint rules
This commit makes isString() a reusable utility
function for core's custom ESLint rules.
PR-URL: https://github.com/nodejs/node/pull/27719
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'tools/eslint-rules/require-common-first.js')
-rw-r--r-- | tools/eslint-rules/require-common-first.js | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/tools/eslint-rules/require-common-first.js b/tools/eslint-rules/require-common-first.js index 2b04a98d9f..4096ee2771 100644 --- a/tools/eslint-rules/require-common-first.js +++ b/tools/eslint-rules/require-common-first.js @@ -4,7 +4,7 @@ 'use strict'; const path = require('path'); -const { isRequireCall } = require('./rules-utils.js'); +const { isRequireCall, isString } = require('./rules-utils.js'); //------------------------------------------------------------------------------ // Rule Definition @@ -16,15 +16,6 @@ module.exports = function(context) { const foundModules = []; /** - * Function to check if a node is a string literal. - * @param {ASTNode} node The node to check. - * @returns {boolean} If the node is a string literal. - */ - function isString(node) { - return node && node.type === 'Literal' && typeof node.value === 'string'; - } - - /** * Function to check if the path is a module and return its name. * @param {String} str The path to check * @returns {String} module name |