summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorKevin Thomas <kevintab95@gmail.com>2018-06-19 20:09:03 +0530
committerRich Trott <rtrott@gmail.com>2018-06-20 10:09:08 -0700
commitfea3595c2f92beb0d31feb93da1c972cc30e6fec (patch)
tree6060db0843ec832f3704cb5d4dcd61e33d59ca55 /test
parente43d91cdc1dc08dc160ef49729f47819332af3ae (diff)
downloadandroid-node-v8-fea3595c2f92beb0d31feb93da1c972cc30e6fec.tar.gz
android-node-v8-fea3595c2f92beb0d31feb93da1c972cc30e6fec.tar.bz2
android-node-v8-fea3595c2f92beb0d31feb93da1c972cc30e6fec.zip
test: remove the third string literal argument from assert.strictEqual()
Third string literal argument in assert.strictEqual() needs to be removed. Otherwise, on AssertionError it would not display the values that failed the check -- this hinders debugging. The string literals are added as comments above the check. PR-URL: https://github.com/nodejs/node/pull/21406 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-string-decoder-end.js6
1 files changed, 4 insertions, 2 deletions
diff --git a/test/parallel/test-string-decoder-end.js b/test/parallel/test-string-decoder-end.js
index 2762ef0962..c686b19b71 100644
--- a/test/parallel/test-string-decoder-end.js
+++ b/test/parallel/test-string-decoder-end.js
@@ -103,8 +103,10 @@ function testBuf(encoding, buf) {
// .toString() on the buffer
const res3 = buf.toString(encoding);
- assert.strictEqual(res1, res3, 'one byte at a time should match toString');
- assert.strictEqual(res2, res3, 'all bytes at once should match toString');
+ // One byte at a time should match toString
+ assert.strictEqual(res1, res3);
+ // All bytes at once should match toString
+ assert.strictEqual(res2, res3);
}
function testEnd(encoding, incomplete, next, expected) {