diff options
author | Fedor Indutny <fedor.indutny@gmail.com> | 2014-01-24 16:25:11 +0400 |
---|---|---|
committer | Fedor Indutny <fedor@indutny.com> | 2014-04-08 00:40:22 +0400 |
commit | f2b297cc7ca1a7a4f4abd356bd1ad0af09e1b26b (patch) | |
tree | 512c383d977a108dc9c132e03a0fbc54fb099e63 /test | |
parent | c2d32f4c0e60a31e6ee421f8f7f45541792c5c6d (diff) | |
download | android-node-v8-f2b297cc7ca1a7a4f4abd356bd1ad0af09e1b26b.tar.gz android-node-v8-f2b297cc7ca1a7a4f4abd356bd1ad0af09e1b26b.tar.bz2 android-node-v8-f2b297cc7ca1a7a4f4abd356bd1ad0af09e1b26b.zip |
http: do not emit EOF non-readable socket
Socket may become not `readable`, but http should not rely on this
property and should not think that it means that no data will ever
arrive from it. In fact, it may arrive in a next tick and, since
`this.push(null)` was already called, it will result in a error like
this:
Error: stream.push() after EOF
at readableAddChunk (_stream_readable.js:143:15)
at IncomingMessage.Readable.push (_stream_readable.js:123:10)
at HTTPParser.parserOnBody (_http_common.js:132:22)
at Socket.socketOnData (_http_client.js:277:20)
at Socket.EventEmitter.emit (events.js:101:17)
at Socket.Readable.read (_stream_readable.js:367:10)
at Socket.socketCloseListener (_http_client.js:196:10)
at Socket.EventEmitter.emit (events.js:123:20)
at TCP.close (net.js:479:12)
fix #6784
Diffstat (limited to 'test')
-rw-r--r-- | test/simple/test-http-client-readable.js | 96 |
1 files changed, 96 insertions, 0 deletions
diff --git a/test/simple/test-http-client-readable.js b/test/simple/test-http-client-readable.js new file mode 100644 index 0000000000..0b26afbe96 --- /dev/null +++ b/test/simple/test-http-client-readable.js @@ -0,0 +1,96 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); +var http = require('http'); +var util = require('util'); + +var Duplex = require('stream').Duplex; + +function FakeAgent() { + http.Agent.call(this); + + this.createConnection = FakeAgent.prototype.createConnection; +} +util.inherits(FakeAgent, http.Agent); + +FakeAgent.prototype.createConnection = function createConnection() { + var s = new Duplex(); + + function ondata(str) { + var buf = new Buffer(str); + s.ondata(buf, 0, buf.length); + } + + Object.defineProperty(s, 'ondata', { + configurable: true, + set: function(value) { + Object.defineProperty(s, 'ondata', { value: value }); + + process.nextTick(function() { + ondata('HTTP/1.1 200 Ok\r\nTransfer-Encoding: chunked\r\n\r\n'); + + s.readable = false; + ondata('b\r\nhello world\r\n'); + ondata('b\r\n ohai world\r\n'); + ondata('0\r\n\r\n'); + }); + } + }); + + // Blackhole + s._write = function write(data, enc, cb) { + cb(); + }; + + s.destroy = s.destroySoon = function destroy() { + this.writable = false; + }; + + return s; +}; + +var received = ''; +var ended = 0; +var response; + +var req = http.request({ + agent: new FakeAgent() +}, function(res) { + response = res; + + res.on('readable', function() { + var chunk = res.read(); + if (chunk !== null) + received += chunk; + }); + + res.on('end', function() { + ended++; + }); +}); +req.end(); + +process.on('exit', function() { + assert.equal(received, 'hello world ohai world'); + assert.equal(ended, 1); +}); |