summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorweewey <chuayewwee@gmail.com>2017-04-26 22:20:35 +0800
committerJames M Snell <jasnell@gmail.com>2017-04-28 06:57:22 -0700
commitf11d4a1556a5536d69c1ae524822a709689c46ac (patch)
tree122fb5d217d4700060271f7046a62c535e8f1764 /test
parent972bfe15143ff203bb576c1be69669e4e69dfb8d (diff)
downloadandroid-node-v8-f11d4a1556a5536d69c1ae524822a709689c46ac.tar.gz
android-node-v8-f11d4a1556a5536d69c1ae524822a709689c46ac.tar.bz2
android-node-v8-f11d4a1556a5536d69c1ae524822a709689c46ac.zip
test: use common.mustCall in test-https-strict
PR-URL: https://github.com/nodejs/node/pull/12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-https-strict.js10
1 files changed, 2 insertions, 8 deletions
diff --git a/test/parallel/test-https-strict.js b/test/parallel/test-https-strict.js
index 215ce7fe00..70e11d2c8b 100644
--- a/test/parallel/test-https-strict.js
+++ b/test/parallel/test-https-strict.js
@@ -91,8 +91,6 @@ server2.listen(0, listening());
server3.listen(0, listening());
const responseErrors = {};
-let expectResponseCount = 0;
-let responseCount = 0;
let pending = 0;
@@ -147,17 +145,14 @@ function makeReq(path, port, error, host, ca) {
options.headers = { host: host };
}
const req = https.get(options);
- expectResponseCount++;
const server = port === server1.address().port ? server1 :
port === server2.address().port ? server2 :
port === server3.address().port ? server3 :
null;
-
if (!server) throw new Error('invalid port: ' + port);
server.expectCount++;
- req.on('response', (res) => {
- responseCount++;
+ req.on('response', common.mustCall((res) => {
assert.strictEqual(res.connection.authorizationError, error);
responseErrors[path] = res.connection.authorizationError;
pending--;
@@ -167,7 +162,7 @@ function makeReq(path, port, error, host, ca) {
server3.close();
}
res.resume();
- });
+ }));
}
function allListening() {
@@ -220,5 +215,4 @@ process.on('exit', () => {
assert.strictEqual(server1.requests.length, server1.expectCount);
assert.strictEqual(server2.requests.length, server2.expectCount);
assert.strictEqual(server3.requests.length, server3.expectCount);
- assert.strictEqual(responseCount, expectResponseCount);
});