summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMaleDong <maledong_github@outlook.com>2018-09-17 13:50:09 +0800
committerAnna Henningsen <anna@addaleax.net>2018-09-22 15:53:20 +0200
commitee31c28298ce257847e08b1279909a4a3002866d (patch)
treea4c27491e815f57976f0e70aff7c03d365a3ed73 /test
parent70f168b883359ab6bd461372fd61c37c8076b4f9 (diff)
downloadandroid-node-v8-ee31c28298ce257847e08b1279909a4a3002866d.tar.gz
android-node-v8-ee31c28298ce257847e08b1279909a4a3002866d.tar.bz2
android-node-v8-ee31c28298ce257847e08b1279909a4a3002866d.zip
test: remove string literals for strictEquals/notStrictEquals
In short: Some unit tests are using string literals to simply tell you a conclusion what's right/wrong BUT not tell you what actually values are. So it's necessary to print them out in the console. Refs: https://github.com/nodejs/node/pull/22849 PR-URL: https://github.com/nodejs/node/pull/22891 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/fixtures/not-main-module.js5
-rw-r--r--test/parallel/test-async-wrap-trigger-id.js12
2 files changed, 8 insertions, 9 deletions
diff --git a/test/fixtures/not-main-module.js b/test/fixtures/not-main-module.js
index f0bae3db15..247868101f 100644
--- a/test/fixtures/not-main-module.js
+++ b/test/fixtures/not-main-module.js
@@ -20,6 +20,5 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
const assert = require('assert');
-assert.notStrictEqual(module, require.main, 'require.main should not == module');
-assert.notStrictEqual(module, process.mainModule,
- 'process.mainModule should not === module');
+assert.notStrictEqual(module, require.main);
+assert.notStrictEqual(module, process.mainModule);
diff --git a/test/parallel/test-async-wrap-trigger-id.js b/test/parallel/test-async-wrap-trigger-id.js
index 271fe3b107..e8b4682b71 100644
--- a/test/parallel/test-async-wrap-trigger-id.js
+++ b/test/parallel/test-async-wrap-trigger-id.js
@@ -11,18 +11,18 @@ let triggerAsyncId1;
process.nextTick(() => {
process.nextTick(() => {
triggerAsyncId1 = triggerAsyncId();
+ // Async resources having different causal ancestry
+ // should have different triggerAsyncIds
assert.notStrictEqual(
triggerAsyncId0,
- triggerAsyncId1,
- 'Async resources having different causal ancestry ' +
- 'should have different triggerAsyncIds');
+ triggerAsyncId1);
});
process.nextTick(() => {
const triggerAsyncId2 = triggerAsyncId();
+ // Async resources having the same causal ancestry
+ // should have the same triggerAsyncId
assert.strictEqual(
triggerAsyncId1,
- triggerAsyncId2,
- 'Async resources having the same causal ancestry ' +
- 'should have the same triggerAsyncId');
+ triggerAsyncId2);
});
});