summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMichael Dawson <michael_dawson@ca.ibm.com>2019-01-09 22:52:06 -0500
committerMichael Dawson <michael_dawson@ca.ibm.com>2019-01-18 09:48:57 -0500
commited0da636b9bfef614f412b2935add832eda8d778 (patch)
tree8295c475ad31560db7f7339d4b970ad2120b332d /test
parent9315daaf02bb53b51760a8b15ad86a8be147db19 (diff)
downloadandroid-node-v8-ed0da636b9bfef614f412b2935add832eda8d778.tar.gz
android-node-v8-ed0da636b9bfef614f412b2935add832eda8d778.tar.bz2
android-node-v8-ed0da636b9bfef614f412b2935add832eda8d778.zip
test: improve code coverage for i18n
Coverage report for src/node_i18n.cc shows that the Has() method is not covered. This test adds coverage for that method. PR-URL: https://github.com/nodejs/node/pull/25428 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-icu-punycode.js6
1 files changed, 6 insertions, 0 deletions
diff --git a/test/parallel/test-icu-punycode.js b/test/parallel/test-icu-punycode.js
index 2501b1d86e..35dab6232f 100644
--- a/test/parallel/test-icu-punycode.js
+++ b/test/parallel/test-icu-punycode.js
@@ -9,6 +9,12 @@ const { internalBinding } = require('internal/test/binding');
const icu = internalBinding('icu');
const assert = require('assert');
+// test hasConverter method
+assert(icu.hasConverter('utf-8'),
+ 'hasConverter should report coverter exists for utf-8');
+assert(!icu.hasConverter('x'),
+ 'hasConverter should report coverter does not exist for x');
+
const tests = require('../fixtures/url-idna.js');
const fixtures = require('../common/fixtures');
const wptToASCIITests = require(