diff options
author | Benjamin Chen <benjaminlchen@gmail.com> | 2018-08-28 01:51:00 -0400 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-09-17 17:48:44 +0200 |
commit | e2325bcc0415a86a77faf06a8e85503db9f6618f (patch) | |
tree | da86baac51b5e8d0ec8331bf76d8920744809b1a /test | |
parent | 1b92214d097358040efb7d3ec5dff1736f364bc0 (diff) | |
download | android-node-v8-e2325bcc0415a86a77faf06a8e85503db9f6618f.tar.gz android-node-v8-e2325bcc0415a86a77faf06a8e85503db9f6618f.tar.bz2 android-node-v8-e2325bcc0415a86a77faf06a8e85503db9f6618f.zip |
string_decoder: support typed array or data view
Refs: https://github.com/nodejs/node/issues/1826
PR-URL: https://github.com/nodejs/node/pull/22562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-string-decoder.js | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/test/parallel/test-string-decoder.js b/test/parallel/test-string-decoder.js index 6e4f4b121d..c4607672b0 100644 --- a/test/parallel/test-string-decoder.js +++ b/test/parallel/test-string-decoder.js @@ -97,6 +97,17 @@ assert.strictEqual(decoder.lastTotal, 3); assert.strictEqual(decoder.end(), '\ufffd'); +// ArrayBufferView tests +const arrayBufferViewStr = 'String for ArrayBufferView tests\n'; +const inputBuffer = Buffer.from(arrayBufferViewStr.repeat(8), 'utf8'); +for (const expectView of common.getArrayBufferViews(inputBuffer)) { + assert.strictEqual( + decoder.write(expectView), + inputBuffer.toString('utf8') + ); + assert.strictEqual(decoder.end(), ''); +} + decoder = new StringDecoder('utf8'); assert.strictEqual(decoder.write(Buffer.from('E18B', 'hex')), ''); assert.strictEqual(decoder.end(), '\ufffd'); @@ -174,8 +185,8 @@ common.expectsError( { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, - message: 'The "buf" argument must be one of type Buffer, Uint8Array, or' + - ' ArrayBufferView. Received type object' + message: 'The "buf" argument must be one of type Buffer, TypedArray,' + + ' or DataView. Received type object' } ); |