diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2018-11-13 14:34:07 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-01 08:52:56 -0800 |
| commit | e1438025edaf18d490548ba0f75f7ba702493c22 (patch) | |
| tree | 48701c2430ca21424a0341e61166b1c3967aaa9d /test | |
| parent | e9de43549843da9f4f081cce917945878967df7e (diff) | |
| download | android-node-v8-e1438025edaf18d490548ba0f75f7ba702493c22.tar.gz android-node-v8-e1438025edaf18d490548ba0f75f7ba702493c22.tar.bz2 android-node-v8-e1438025edaf18d490548ba0f75f7ba702493c22.zip | |
Revert "url: make the context non-enumerable"
This reverts commit 5e1bf058f4906c0a49c34c6a1353d0b34784c80a, as it
causes major performance regressions during object construction.
Refs: https://github.com/nodejs/node/pull/24218
PR-URL: https://github.com/nodejs/node/pull/24495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/parallel/test-whatwg-url-custom-no-enumerable-context.js | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/test/parallel/test-whatwg-url-custom-no-enumerable-context.js b/test/parallel/test-whatwg-url-custom-no-enumerable-context.js deleted file mode 100644 index f24a47b6d5..0000000000 --- a/test/parallel/test-whatwg-url-custom-no-enumerable-context.js +++ /dev/null @@ -1,14 +0,0 @@ -'use strict'; -// This tests that the context of URL objects are not -// enumerable and thus considered by assert libraries. -// See https://github.com/nodejs/node/issues/24211 - -// Tests below are not from WPT. - -require('../common'); -const assert = require('assert'); - -assert.deepStrictEqual( - new URL('./foo', 'https://example.com/'), - new URL('https://example.com/foo') -); |