diff options
author | Anto Aravinth <anto.aravinth.cse@gmail.com> | 2018-09-04 19:43:25 +0530 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-09-18 13:29:55 +0200 |
commit | dcc0c2c5c9d5bd97cc3df7fe7fd7f34c96e53b5b (patch) | |
tree | 482a3945b82a6e95f3190207c521c2357fe19b6a /test | |
parent | 9ccf5c8954b8260d1a016c9b1442012ad8626bea (diff) | |
download | android-node-v8-dcc0c2c5c9d5bd97cc3df7fe7fd7f34c96e53b5b.tar.gz android-node-v8-dcc0c2c5c9d5bd97cc3df7fe7fd7f34c96e53b5b.tar.bz2 android-node-v8-dcc0c2c5c9d5bd97cc3df7fe7fd7f34c96e53b5b.zip |
lib: move process.binding('js_stream') to internalBinding
PR-URL: https://github.com/nodejs/node/pull/22239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-js-stream-call-properties.js | 5 | ||||
-rw-r--r-- | test/parallel/test-process-binding-internalbinding-whitelist.js | 1 | ||||
-rw-r--r-- | test/parallel/test-util-inspect.js | 3 | ||||
-rw-r--r-- | test/parallel/test-util-types.js | 5 | ||||
-rw-r--r-- | test/parallel/test-v8-serdes.js | 5 | ||||
-rw-r--r-- | test/sequential/test-async-wrap-getasyncid.js | 2 |
6 files changed, 15 insertions, 6 deletions
diff --git a/test/parallel/test-js-stream-call-properties.js b/test/parallel/test-js-stream-call-properties.js index 280e5d9dab..c001fbdb13 100644 --- a/test/parallel/test-js-stream-call-properties.js +++ b/test/parallel/test-js-stream-call-properties.js @@ -1,8 +1,11 @@ +// Flags: --expose-internals + 'use strict'; require('../common'); const util = require('util'); -const JSStream = process.binding('js_stream').JSStream; +const { internalBinding } = require('internal/test/binding'); +const { JSStream } = internalBinding('js_stream'); // Testing if will abort when properties are printed. util.inspect(new JSStream()); diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js index 7076650e1b..56715799f8 100644 --- a/test/parallel/test-process-binding-internalbinding-whitelist.js +++ b/test/parallel/test-process-binding-internalbinding-whitelist.js @@ -14,3 +14,4 @@ assert(process.binding('signal_wrap')); assert(process.binding('contextify')); assert(process.binding('url')); assert(process.binding('spawn_sync')); +assert(process.binding('js_stream')); diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js index 4cd7286f1f..467849cf7a 100644 --- a/test/parallel/test-util-inspect.js +++ b/test/parallel/test-util-inspect.js @@ -20,11 +20,12 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. +// Flags: --expose-internals 'use strict'; const common = require('../common'); const assert = require('assert'); const { internalBinding } = require('internal/test/binding'); -const JSStream = process.binding('js_stream').JSStream; +const { JSStream } = internalBinding('js_stream'); const util = require('util'); const vm = require('vm'); const { previewEntries } = internalBinding('util'); diff --git a/test/parallel/test-util-types.js b/test/parallel/test-util-types.js index 2978cbf98d..64434e574a 100644 --- a/test/parallel/test-util-types.js +++ b/test/parallel/test-util-types.js @@ -1,11 +1,12 @@ -// Flags: --experimental-vm-modules +// Flags: --experimental-vm-modules --expose-internals 'use strict'; require('../common'); const fixtures = require('../common/fixtures'); const assert = require('assert'); const { types, inspect } = require('util'); const vm = require('vm'); -const { JSStream } = process.binding('js_stream'); +const { internalBinding } = require('internal/test/binding'); +const { JSStream } = internalBinding('js_stream'); const external = (new JSStream())._externalStream; const wasmBuffer = fixtures.readSync('test.wasm'); diff --git a/test/parallel/test-v8-serdes.js b/test/parallel/test-v8-serdes.js index ad8666ee3b..94f10dbfe9 100644 --- a/test/parallel/test-v8-serdes.js +++ b/test/parallel/test-v8-serdes.js @@ -1,5 +1,8 @@ +// Flags: --expose-gc --expose-internals + 'use strict'; +const { internalBinding } = require('internal/test/binding'); const common = require('../common'); const assert = require('assert'); const v8 = require('v8'); @@ -20,7 +23,7 @@ const objects = [ circular ]; -const hostObject = new (process.binding('js_stream').JSStream)(); +const hostObject = new (internalBinding('js_stream').JSStream)(); const serializerTypeError = /^TypeError: Class constructor Serializer cannot be invoked without 'new'$/; diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js index aac356df2a..148e4da300 100644 --- a/test/sequential/test-async-wrap-getasyncid.js +++ b/test/sequential/test-async-wrap-getasyncid.js @@ -94,7 +94,7 @@ function testInitialized(req, ctor_name) { { - const JSStream = process.binding('js_stream').JSStream; + const JSStream = internalBinding('js_stream').JSStream; testInitialized(new JSStream(), 'JSStream'); } |