summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2018-12-03 08:23:34 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2018-12-18 18:02:08 +0800
commitceb66352236240498a9263500c7bde74e58c71fa (patch)
tree8f3c1e50ef535cba057f0916e6925c5dab2a6d23 /test
parent8828426af45adc29847d0d20717c8fa3eb9bb523 (diff)
downloadandroid-node-v8-ceb66352236240498a9263500c7bde74e58c71fa.tar.gz
android-node-v8-ceb66352236240498a9263500c7bde74e58c71fa.tar.bz2
android-node-v8-ceb66352236240498a9263500c7bde74e58c71fa.zip
src: remove code cache integrity check
In preparation of sharing code cache among different threads - we simply rely on v8 to reject invalid cache, since there isn't any serious consequence when the cache is invalid anyway. PR-URL: https://github.com/nodejs/node/pull/24950 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test')
-rw-r--r--test/code-cache/test-code-cache-generator.js6
1 files changed, 0 insertions, 6 deletions
diff --git a/test/code-cache/test-code-cache-generator.js b/test/code-cache/test-code-cache-generator.js
index b440d4e58c..78a2b1c9a6 100644
--- a/test/code-cache/test-code-cache-generator.js
+++ b/test/code-cache/test-code-cache-generator.js
@@ -31,7 +31,6 @@ if (child.status !== 0) {
// Verifies that:
// - node::LoadCodeCache()
-// - node::LoadCodeCacheHash()
// are defined in the generated code.
// See src/node_native_module.h for explanations.
@@ -41,18 +40,13 @@ const rl = readline.createInterface({
});
let hasCacheDef = false;
-let hasHashDef = false;
rl.on('line', common.mustCallAtLeast((line) => {
if (line.includes('LoadCodeCache(')) {
hasCacheDef = true;
}
- if (line.includes('LoadCodeCacheHash(')) {
- hasHashDef = true;
- }
}, 2));
rl.on('close', common.mustCall(() => {
assert.ok(hasCacheDef);
- assert.ok(hasHashDef);
}));