diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-02-01 11:12:19 -0800 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-02-06 15:17:40 -0800 |
commit | cdd6eb237b8393531a1beeef00901e89e5279c0a (patch) | |
tree | 089f7c32e1b33518909d075fd0111f68ac3fe6b3 /test | |
parent | 5d52c8e43cb6633f7a71af403030d1eee070773a (diff) | |
download | android-node-v8-cdd6eb237b8393531a1beeef00901e89e5279c0a.tar.gz android-node-v8-cdd6eb237b8393531a1beeef00901e89e5279c0a.tar.bz2 android-node-v8-cdd6eb237b8393531a1beeef00901e89e5279c0a.zip |
test: wait for TCP connect, not TLS handshake
Test assumed server gets a handshake before the client destroyed it, and
didn't assert that dns.lookup() callback occurred.
PR-URL: https://github.com/nodejs/node/pull/25508
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-tls-connect-address-family.js | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/test/parallel/test-tls-connect-address-family.js b/test/parallel/test-tls-connect-address-family.js index 569688ca8a..083208cc1d 100644 --- a/test/parallel/test-tls-connect-address-family.js +++ b/test/parallel/test-tls-connect-address-family.js @@ -15,7 +15,7 @@ function runTest() { tls.createServer({ cert: fixtures.readKey('agent1-cert.pem'), key: fixtures.readKey('agent1-key.pem'), - }, common.mustCall(function() { + }).on('connection', common.mustCall(function() { this.close(); })).listen(0, '::1', common.mustCall(function() { const options = { @@ -32,7 +32,9 @@ function runTest() { })); } -dns.lookup('localhost', { family: 6, all: true }, (err, addresses) => { +dns.lookup('localhost', { + family: 6, all: true +}, common.mustCall((err, addresses) => { if (err) { if (err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN') common.skip('localhost does not resolve to ::1'); @@ -44,4 +46,4 @@ dns.lookup('localhost', { family: 6, all: true }, (err, addresses) => { runTest(); else common.skip('localhost does not resolve to ::1'); -}); +})); |