diff options
author | Rich Trott <rtrott@gmail.com> | 2018-06-04 17:34:37 +0000 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-06-06 21:04:25 -0700 |
commit | cdd2e96a2dfe4022cb7e24aa71b9d40c43ff8102 (patch) | |
tree | a9ebfed79930ec621f5ce7b8bdb549b0613065c3 /test | |
parent | 41e5253e7c82a79b8f51eff6fd8a6fbb73af69c1 (diff) | |
download | android-node-v8-cdd2e96a2dfe4022cb7e24aa71b9d40c43ff8102.tar.gz android-node-v8-cdd2e96a2dfe4022cb7e24aa71b9d40c43ff8102.tar.bz2 android-node-v8-cdd2e96a2dfe4022cb7e24aa71b9d40c43ff8102.zip |
test,tools: refactor custom ESLint for readability
Refactor the test and the source for the `lowercase-name-for-primitive`
custom ESLint rule for readability.
PR-URL: https://github.com/nodejs/node/pull/21134
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-eslint-lowercase-name-for-primitive.js | 38 |
1 files changed, 13 insertions, 25 deletions
diff --git a/test/parallel/test-eslint-lowercase-name-for-primitive.js b/test/parallel/test-eslint-lowercase-name-for-primitive.js index 929ff03c65..f196f3f45c 100644 --- a/test/parallel/test-eslint-lowercase-name-for-primitive.js +++ b/test/parallel/test-eslint-lowercase-name-for-primitive.js @@ -7,45 +7,33 @@ common.skipIfEslintMissing(); const RuleTester = require('../../tools/node_modules/eslint').RuleTester; const rule = require('../../tools/eslint-rules/lowercase-name-for-primitive'); -const valid = [ - 'string', - 'number', - 'boolean', - 'null', - 'undefined' -]; - new RuleTester().run('lowercase-name-for-primitive', rule, { valid: [ 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", ["string", "number"])', - ...valid.map((name) => - `new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "${name}")` - ) + 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "string")', + 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "number")', + 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "boolean")', + 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "null")', + 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "name", "undefined")', ], invalid: [ { - code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '\'Number\')', + code: "new errors.TypeError('ERR_INVALID_ARG_TYPE', 'a', 'Number')", errors: [{ message: 'primitive should use lowercase: Number' }], - output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '\'number\')' + output: "new errors.TypeError('ERR_INVALID_ARG_TYPE', 'a', 'number')", }, { - code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '\'STRING\')', + code: "new errors.TypeError('ERR_INVALID_ARG_TYPE', 'a', 'STRING')", errors: [{ message: 'primitive should use lowercase: STRING' }], - output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '\'string\')' + output: "new errors.TypeError('ERR_INVALID_ARG_TYPE', 'a', 'string')", }, { - code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '[\'String\', \'Number\']) ', + code: "new e.TypeError('ERR_INVALID_ARG_TYPE', a, ['String','Number'])", errors: [ { message: 'primitive should use lowercase: String' }, - { message: 'primitive should use lowercase: Number' } + { message: 'primitive should use lowercase: Number' }, ], - output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + - '[\'string\', \'number\']) ' - } + output: "new e.TypeError('ERR_INVALID_ARG_TYPE', a, ['string','number'])", + }, ] }); |