diff options
author | Julien Gilli <julien.gilli@joyent.com> | 2014-12-18 16:51:08 -0800 |
---|---|---|
committer | Fedor Indutny <fedor@indutny.com> | 2015-04-04 02:30:33 +0300 |
commit | cca5efb086b0c9d0e78be3ce0b9690f16e6f0ad9 (patch) | |
tree | 13547eefe12a11e51f611baa1cc4762177b264ba /test | |
parent | 0e061975d76a1c067204c1752d01227466561b1e (diff) | |
download | android-node-v8-cca5efb086b0c9d0e78be3ce0b9690f16e6f0ad9.tar.gz android-node-v8-cca5efb086b0c9d0e78be3ce0b9690f16e6f0ad9.tar.bz2 android-node-v8-cca5efb086b0c9d0e78be3ce0b9690f16e6f0ad9.zip |
timers: don't close interval timers when unrefd
This change fixes a regression introduced by commit
0d051238be2e07e671d7d9f4f444e0cc1efadf1b, which contained a typo that
would cause every unrefd interval to fire only once.
Fixes: https://github.com/joyent/node/issues/8900
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-timers-unrefd-interval-still-fires.js | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/test/parallel/test-timers-unrefd-interval-still-fires.js b/test/parallel/test-timers-unrefd-interval-still-fires.js new file mode 100644 index 0000000000..3ea94454cf --- /dev/null +++ b/test/parallel/test-timers-unrefd-interval-still-fires.js @@ -0,0 +1,18 @@ +/* + * This test is a regression test for joyent/node#8900. + */ +var assert = require('assert'); + +var N = 5; +var nbIntervalFired = 0; +var timer = setInterval(function() { + ++nbIntervalFired; + if (nbIntervalFired === N) + clearInterval(timer); +}, 1); + +timer.unref(); + +setTimeout(function onTimeout() { + assert.strictEqual(nbIntervalFired, N); +}, 100); |