summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-08-21 22:01:38 -0700
committerRich Trott <rtrott@gmail.com>2019-08-22 22:51:33 -0700
commitcb9212695507c552ae08cbfdbefd0055c708c307 (patch)
treedba9e2d32df5822ed50681788b1cd24766734710 /test
parenteeea3fb91b8dd177cf284a9cf7de0aec008c4e84 (diff)
downloadandroid-node-v8-cb9212695507c552ae08cbfdbefd0055c708c307.tar.gz
android-node-v8-cb9212695507c552ae08cbfdbefd0055c708c307.tar.bz2
android-node-v8-cb9212695507c552ae08cbfdbefd0055c708c307.zip
test: add `emitClose: true` tests for fs streams
PR-URL: https://github.com/nodejs/node/pull/29212 Fixes: https://github.com/nodejs/node/issues/29177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-fs-stream-destroy-emit-error.js27
1 files changed, 25 insertions, 2 deletions
diff --git a/test/parallel/test-fs-stream-destroy-emit-error.js b/test/parallel/test-fs-stream-destroy-emit-error.js
index c0405ce5f1..c1db9547a8 100644
--- a/test/parallel/test-fs-stream-destroy-emit-error.js
+++ b/test/parallel/test-fs-stream-destroy-emit-error.js
@@ -6,8 +6,31 @@ const fs = require('fs');
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();
-test(fs.createReadStream(__filename));
-test(fs.createWriteStream(`${tmpdir.path}/dummy`));
+{
+ const stream = fs.createReadStream(__filename);
+ stream.on('close', common.mustNotCall());
+ test(stream);
+}
+
+{
+ const stream = fs.createWriteStream(`${tmpdir.path}/dummy`);
+ stream.on('close', common.mustNotCall());
+ test(stream);
+}
+
+{
+ const stream = fs.createReadStream(__filename, { emitClose: true });
+ stream.on('close', common.mustCall());
+ test(stream);
+}
+
+{
+ const stream = fs.createWriteStream(`${tmpdir.path}/dummy2`,
+ { emitClose: true });
+ stream.on('close', common.mustCall());
+ test(stream);
+}
+
function test(stream) {
const err = new Error('DESTROYED');