diff options
author | Anna Henningsen <anna@addaleax.net> | 2017-11-18 16:37:07 +0100 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2017-11-21 13:57:05 +0100 |
commit | c4a5de51e936940c9abce7761f2856ebf9202330 (patch) | |
tree | 6cd001b76ad6461da743f839c4bb18d6bd78eaa2 /test | |
parent | 5d7f5c16b3ae49325b7bb0a79eaba3e945585ced (diff) | |
download | android-node-v8-c4a5de51e936940c9abce7761f2856ebf9202330.tar.gz android-node-v8-c4a5de51e936940c9abce7761f2856ebf9202330.tar.bz2 android-node-v8-c4a5de51e936940c9abce7761f2856ebf9202330.zip |
inspector: no async tracking for promises
`Promise` instances are already tracked by V8 itself.
This fixes `sequential/test-inspector-async-stack-traces-promise-then`
in debug mode (it previously crashed because our tracking
and the V8 tracking were not properly nested).
PR-URL: https://github.com/nodejs/node/pull/17118
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/707058
Fixes: https://github.com/nodejs/node/issues/17017
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/sequential/test-inspector-async-stack-traces-promise-then.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/sequential/test-inspector-async-stack-traces-promise-then.js b/test/sequential/test-inspector-async-stack-traces-promise-then.js index a321855b5e..9ed61d5ae1 100644 --- a/test/sequential/test-inspector-async-stack-traces-promise-then.js +++ b/test/sequential/test-inspector-async-stack-traces-promise-then.js @@ -54,7 +54,7 @@ function debuggerPausedAt(msg, functionName, previousTickLocation) { `${Object.keys(msg.params)} contains "asyncStackTrace" property`); assert.strictEqual(msg.params.callFrames[0].functionName, functionName); - assert.strictEqual(msg.params.asyncStackTrace.description, 'PROMISE'); + assert.strictEqual(msg.params.asyncStackTrace.description, 'Promise.resolve'); const frameLocations = msg.params.asyncStackTrace.callFrames.map( (frame) => `${frame.functionName}:${frame.lineNumber}`); |