diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-08-03 20:47:32 +0200 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2018-08-12 10:40:10 -0700 |
commit | c3bd65146e95968edf81b70f51823e0f44e701f2 (patch) | |
tree | b56495188fee17cd97a0f0c641b1529b85f7e907 /test | |
parent | c7ca199c381049f63a97b9aef09daa5e7f8edc7c (diff) | |
download | android-node-v8-c3bd65146e95968edf81b70f51823e0f44e701f2.tar.gz android-node-v8-c3bd65146e95968edf81b70f51823e0f44e701f2.tar.bz2 android-node-v8-c3bd65146e95968edf81b70f51823e0f44e701f2.zip |
test: improve test coverage for comparisons
PR-URL: https://github.com/nodejs/node/pull/22212
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-assert-deep.js | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js index 08491421f6..12876232ed 100644 --- a/test/parallel/test-assert-deep.js +++ b/test/parallel/test-assert-deep.js @@ -372,6 +372,7 @@ assertOnlyDeepEqual( new Map([[null, undefined]]), new Map([[undefined, null]]) ); + assertOnlyDeepEqual( new Set([null, '']), new Set([undefined, 0]) @@ -380,6 +381,10 @@ assertNotDeepOrStrict( new Set(['']), new Set(['0']) ); +assertOnlyDeepEqual( + new Map([[1, {}]]), + new Map([[true, {}]]) +); // GH-6416. Make sure circular refs don't throw. { @@ -556,13 +561,12 @@ assertOnlyDeepEqual([1, , , 3], [1, , , 3, , , ]); // Handle different error messages { const err1 = new Error('foo1'); - const err2 = new Error('foo2'); - const err3 = new TypeError('foo1'); - assertNotDeepOrStrict(err1, err2, assert.AssertionError); - assertNotDeepOrStrict(err1, err3, assert.AssertionError); + assertNotDeepOrStrict(err1, new Error('foo2'), assert.AssertionError); + assertNotDeepOrStrict(err1, new TypeError('foo1'), assert.AssertionError); + assertDeepAndStrictEqual(err1, new Error('foo1')); // TODO: evaluate if this should throw or not. The same applies for RegExp // Date and any object that has the same keys but not the same prototype. - assertOnlyDeepEqual(err1, {}, assert.AssertionError); + assertOnlyDeepEqual(err1, {}); } // Handle NaN |