diff options
author | Rich Trott <rtrott@gmail.com> | 2019-01-13 20:35:52 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-01-16 06:49:15 -0800 |
commit | b39234a4a8c9c360a3bff46b6c10f696a542eb23 (patch) | |
tree | 17316759c5eea591a05ab9322f887271d75c05d1 /test | |
parent | 46fb276529246dd08c594a83c26fe37e7b622006 (diff) | |
download | android-node-v8-b39234a4a8c9c360a3bff46b6c10f696a542eb23.tar.gz android-node-v8-b39234a4a8c9c360a3bff46b6c10f696a542eb23.tar.bz2 android-node-v8-b39234a4a8c9c360a3bff46b6c10f696a542eb23.zip |
test: refactor pummel/test-net-connect-econnrefused
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test
failures as a result of side effects from other tests. (For my local
setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT
and/or EADDRNOTAVAIL. It would seem to be a result of throttling.
Reducing the pummel-iness of that test and this one seems to solve the
problem.)
* Apply capitalization and punctuation to comment.
PR-URL: https://github.com/nodejs/node/pull/25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r-- | test/pummel/test-net-connect-econnrefused.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/pummel/test-net-connect-econnrefused.js b/test/pummel/test-net-connect-econnrefused.js index 0f350bd572..39737f73bf 100644 --- a/test/pummel/test-net-connect-econnrefused.js +++ b/test/pummel/test-net-connect-econnrefused.js @@ -20,14 +20,14 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// verify that connect reqs are properly cleaned up +// Verify that connect reqs are properly cleaned up. const common = require('../common'); const assert = require('assert'); const net = require('net'); -const ROUNDS = 10; -const ATTEMPTS_PER_ROUND = 100; +const ROUNDS = 5; +const ATTEMPTS_PER_ROUND = 50; let rounds = 1; let reqs = 0; |