diff options
author | XadillaX <i@2333.moe> | 2018-03-21 12:11:40 +0800 |
---|---|---|
committer | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-04-03 15:43:40 -0700 |
commit | b06f686f8878027ccbd08b36b546378ffc0addfd (patch) | |
tree | 9849e6d4faaa1423b117664123584caa2a828319 /test | |
parent | 2ec69955556bf92f49355659b6126e08fa2c3298 (diff) | |
download | android-node-v8-b06f686f8878027ccbd08b36b546378ffc0addfd.tar.gz android-node-v8-b06f686f8878027ccbd08b36b546378ffc0addfd.tar.bz2 android-node-v8-b06f686f8878027ccbd08b36b546378ffc0addfd.zip |
http: fix `request` when `setHost` is `true`
Fixes: https://github.com/nodejs/node/issues/19457
PR-URL: https://github.com/nodejs/node/pull/19502
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-https-host-headers.js | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/test/parallel/test-https-host-headers.js b/test/parallel/test-https-host-headers.js index a1330ad73a..11fa8dd70f 100644 --- a/test/parallel/test-https-host-headers.js +++ b/test/parallel/test-https-host-headers.js @@ -16,7 +16,7 @@ const httpsServer = https.createServer(options, reqHandler); function reqHandler(req, res) { console.log(`Got request: ${req.headers.host} ${req.url}`); - if (req.url === '/setHostFalse5') { + if (req.url.startsWith('/setHostFalse')) { assert.strictEqual(req.headers.host, undefined); } else { assert.strictEqual( @@ -97,6 +97,34 @@ function testHttps() { setHost: false, port: this.address().port, rejectUnauthorized: false + }, cb).on('error', thrower); + + https.request({ + method: 'GET', + path: `/${counter++}`, + host: 'localhost', + setHost: true, + //agent: false, + port: this.address().port, + rejectUnauthorized: false }, cb).on('error', thrower).end(); + + https.get({ + method: 'GET', + path: `/setHostFalse${counter++}`, + host: 'localhost', + setHost: 0, + port: this.address().port, + rejectUnauthorized: false + }, cb).on('error', thrower); + + https.get({ + method: 'GET', + path: `/setHostFalse${counter++}`, + host: 'localhost', + setHost: null, + port: this.address().port, + rejectUnauthorized: false + }, cb).on('error', thrower); }); } |