diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-09-25 14:51:18 +0200 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-09-27 16:26:42 -0700 |
commit | aea9a0f77da6a14d4fee2b21b0f4a6a813a01e70 (patch) | |
tree | 6f7c7d54c21337d2debdf00419e03aee3144318e /test | |
parent | c2ce8d05474c38c503b6ac57e94366421c960762 (diff) | |
download | android-node-v8-aea9a0f77da6a14d4fee2b21b0f4a6a813a01e70.tar.gz android-node-v8-aea9a0f77da6a14d4fee2b21b0f4a6a813a01e70.tar.bz2 android-node-v8-aea9a0f77da6a14d4fee2b21b0f4a6a813a01e70.zip |
worker: fix process._fatalException return type
This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.
PR-URL: https://github.com/nodejs/node/pull/29706
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-worker-non-fatal-uncaught-exception.js | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/test/parallel/test-worker-non-fatal-uncaught-exception.js b/test/parallel/test-worker-non-fatal-uncaught-exception.js new file mode 100644 index 0000000000..01df55eec1 --- /dev/null +++ b/test/parallel/test-worker-non-fatal-uncaught-exception.js @@ -0,0 +1,25 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const { Worker } = require('worker_threads'); + +// Check that `process._fatalException()` returns a boolean when run inside a +// worker. + +// Do not use isMainThread so that this test itself can be run inside a Worker. +if (!process.env.HAS_STARTED_WORKER) { + process.env.HAS_STARTED_WORKER = 1; + const w = new Worker(__filename); + w.on('exit', common.mustCall((code) => { + assert.strictEqual(code, 0); + })); + return; +} + +process.once('uncaughtException', () => { + process.nextTick(() => { + assert.strictEqual(res, true); + }); +}); + +const res = process._fatalException(new Error()); |