aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorTyler Vann-Campbell <tyler@buddy.com>2018-10-12 10:03:45 -0700
committerRuben Bridgewater <ruben@bridgewater.de>2018-10-15 12:00:00 +0200
commitad6b09f7099846f7db49c88e2aacffe6a789c73f (patch)
tree745413899ae6a02075858b5c55222ba86162a7da /test
parent101812e0a93ba26b84500dc58220f947dd8ff94c (diff)
downloadandroid-node-v8-ad6b09f7099846f7db49c88e2aacffe6a789c73f.tar.gz
android-node-v8-ad6b09f7099846f7db49c88e2aacffe6a789c73f.tar.bz2
android-node-v8-ad6b09f7099846f7db49c88e2aacffe6a789c73f.zip
test: use the correct parameter order on assert.strictEqual()
The parameter order for assert.strictEqual() should be actual, expected rather than expected, actual which can make test failure messages confusing. This change reverses the order of the assertion to match the documented parameter order. PR-URL: https://github.com/nodejs/node/pull/23520 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r--test/pummel/test-net-many-clients.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/pummel/test-net-many-clients.js b/test/pummel/test-net-many-clients.js
index 657b03abde..db7da1ae04 100644
--- a/test/pummel/test-net-many-clients.js
+++ b/test/pummel/test-net-many-clients.js
@@ -70,8 +70,8 @@ function runClient(callback) {
client.on('close', function(had_error) {
console.log('.');
- assert.strictEqual(false, had_error);
- assert.strictEqual(bytes, client.recved.length);
+ assert.strictEqual(had_error, false);
+ assert.strictEqual(client.recved.length, bytes);
if (client.fd) {
console.log(client.fd);
@@ -96,6 +96,6 @@ server.listen(common.PORT, function() {
});
process.on('exit', function() {
- assert.strictEqual(connections_per_client * concurrency, total_connections);
+ assert.strictEqual(total_connections, connections_per_client * concurrency);
console.log('\nokay!');
});