summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMichaƫl Zasso <targos@protonmail.com>2019-10-22 15:28:34 +0200
committerRich Trott <rtrott@gmail.com>2019-10-26 16:22:39 -0700
commitab78d4df34a7698c45fca0b81300fd02fc4add7b (patch)
tree798c500f726abfc0ba8a1eac9f9422b49d4b8e71 /test
parentd29f0eda152b0407bf6bd1e63f548bd39cd2fcd3 (diff)
downloadandroid-node-v8-ab78d4df34a7698c45fca0b81300fd02fc4add7b.tar.gz
android-node-v8-ab78d4df34a7698c45fca0b81300fd02fc4add7b.tar.bz2
android-node-v8-ab78d4df34a7698c45fca0b81300fd02fc4add7b.zip
src: fix crash with SyntheticModule#setExport
Use the new non-deprecated V8 API for that. PR-URL: https://github.com/nodejs/node/pull/30062 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-vm-module-synthetic.js3
1 files changed, 0 insertions, 3 deletions
diff --git a/test/parallel/test-vm-module-synthetic.js b/test/parallel/test-vm-module-synthetic.js
index 71df9bd263..83a78f2f3f 100644
--- a/test/parallel/test-vm-module-synthetic.js
+++ b/test/parallel/test-vm-module-synthetic.js
@@ -36,8 +36,6 @@ const assert = require('assert');
});
}
- // https://bugs.chromium.org/p/v8/issues/detail?id=9828
- /*
{
const s = new SyntheticModule([], () => {});
await s.link(() => {});
@@ -47,7 +45,6 @@ const assert = require('assert');
name: 'ReferenceError',
});
}
- */
{
const s = new SyntheticModule([], () => {});