diff options
author | Julien Gilli <jgilli@netflix.com> | 2018-10-03 15:47:01 -0700 |
---|---|---|
committer | Julien Gilli <jgilli@netflix.com> | 2018-10-05 12:35:58 -0700 |
commit | a8526cb5a46df0cd8052ca1a13cab78e0e0c6a4b (patch) | |
tree | 8fd5743c87f7741d2f78d01b296910c4c47e499b /test | |
parent | 2cf6a9483978c987351c5469d89bba6c37f95535 (diff) | |
download | android-node-v8-a8526cb5a46df0cd8052ca1a13cab78e0e0c6a4b.tar.gz android-node-v8-a8526cb5a46df0cd8052ca1a13cab78e0e0c6a4b.tar.bz2 android-node-v8-a8526cb5a46df0cd8052ca1a13cab78e0e0c6a4b.zip |
test: remove obsolete domain test
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
https://github.com/nodejs/node/pull/1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
R-URL: https://github.com/nodejs/node/pull/23252
Refs: https://github.com/nodejs/node/pull/16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-microtask-queue-run-immediate-domain.js | 66 |
1 files changed, 0 insertions, 66 deletions
diff --git a/test/parallel/test-microtask-queue-run-immediate-domain.js b/test/parallel/test-microtask-queue-run-immediate-domain.js deleted file mode 100644 index 60b17bc38c..0000000000 --- a/test/parallel/test-microtask-queue-run-immediate-domain.js +++ /dev/null @@ -1,66 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -'use strict'; -require('../common'); -const assert = require('assert'); - -// Requiring the domain module here changes the function that is used by node to -// call process.nextTick's callbacks to a variant that specifically handles -// domains. We want to test this specific variant in this test, and so even if -// the domain module is not used, this require call is needed and must not be -// removed. -require('domain'); - -function enqueueMicrotask(fn) { - Promise.resolve().then(fn); -} - -let done = 0; - -process.on('exit', function() { - assert.strictEqual(done, 2); -}); - -// no nextTick, microtask -setImmediate(function() { - enqueueMicrotask(function() { - done++; - }); -}); - - -// no nextTick, microtask with nextTick -setImmediate(function() { - let called = false; - - enqueueMicrotask(function() { - process.nextTick(function() { - called = true; - }); - }); - - setImmediate(function() { - if (called) - done++; - }); - -}); |