diff options
author | David Cai <davidcai1993@yahoo.com> | 2017-05-05 15:08:59 +0800 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2017-05-07 22:20:33 +0200 |
commit | a710e443a28552dece3453ab7b7b8306489ecf85 (patch) | |
tree | e5d21ab220644ac9d7fef73c31a9d0326d036cfa /test | |
parent | 7e5f500c9861708e221e1e5e1d42e92af234583b (diff) | |
download | android-node-v8-a710e443a28552dece3453ab7b7b8306489ecf85.tar.gz android-node-v8-a710e443a28552dece3453ab7b7b8306489ecf85.tar.bz2 android-node-v8-a710e443a28552dece3453ab7b7b8306489ecf85.zip |
test: complete coverage of buffer
PR-URL: https://github.com/nodejs/node/pull/12831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-buffer-bytelength.js | 9 | ||||
-rw-r--r-- | test/parallel/test-buffer-tostring.js | 13 | ||||
-rw-r--r-- | test/parallel/test-buffer-write.js | 9 |
3 files changed, 29 insertions, 2 deletions
diff --git a/test/parallel/test-buffer-bytelength.js b/test/parallel/test-buffer-bytelength.js index b140478933..09e59743e4 100644 --- a/test/parallel/test-buffer-bytelength.js +++ b/test/parallel/test-buffer-bytelength.js @@ -106,3 +106,12 @@ assert.strictEqual(Buffer.byteLength('Il était tué', 'utf8'), 14); // Test that ArrayBuffer from a different context is detected correctly const arrayBuf = vm.runInNewContext('new ArrayBuffer()'); assert.strictEqual(Buffer.byteLength(arrayBuf), 0); + +// Verify that invalid encodings are treated as utf8 +for (let i = 1; i < 10; i++) { + const encoding = String(i).repeat(i); + + assert.ok(!Buffer.isEncoding(encoding)); + assert.strictEqual(Buffer.byteLength('foo', encoding), + Buffer.byteLength('foo', 'utf8')); +} diff --git a/test/parallel/test-buffer-tostring.js b/test/parallel/test-buffer-tostring.js index 776b7c0892..214d1013e9 100644 --- a/test/parallel/test-buffer-tostring.js +++ b/test/parallel/test-buffer-tostring.js @@ -4,8 +4,8 @@ require('../common'); const assert = require('assert'); // utf8, ucs2, ascii, latin1, utf16le -const encodings = ['utf8', 'ucs2', 'ucs-2', 'ascii', 'latin1', 'binary', - 'utf16le', 'utf-16le']; +const encodings = ['utf8', 'utf-8', 'ucs2', 'ucs-2', 'ascii', 'latin1', + 'binary', 'utf16le', 'utf-16le']; encodings .reduce((es, e) => es.concat(e, e.toUpperCase()), []) @@ -23,3 +23,12 @@ encodings assert.strictEqual(Buffer.from('666f6f', encoding).toString(encoding), '666f6f'); }); + +// Invalid encodings +for (let i = 1; i < 10; i++) { + const encoding = String(i).repeat(i); + const error = new RegExp(`^TypeError: Unknown encoding: ${encoding}$`); + + assert.ok(!Buffer.isEncoding(encoding)); + assert.throws(() => Buffer.from('foo').toString(encoding), error); +} diff --git a/test/parallel/test-buffer-write.js b/test/parallel/test-buffer-write.js index 80c95dda44..f278b92cce 100644 --- a/test/parallel/test-buffer-write.js +++ b/test/parallel/test-buffer-write.js @@ -53,3 +53,12 @@ encodings assert.strictEqual(buf.write('666f6f', 0, len, encoding), len); assert.deepStrictEqual(buf, resultMap.get(encoding.toLowerCase())); }); + +// Invalid encodings +for (let i = 1; i < 10; i++) { + const encoding = String(i).repeat(i); + const error = new RegExp(`^TypeError: Unknown encoding: ${encoding}$`); + + assert.ok(!Buffer.isEncoding(encoding)); + assert.throws(() => Buffer.alloc(9).write('foo', encoding), error); +} |