summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMasashi Hirano <cherrydog07@gmail.com>2018-09-20 01:33:52 +0900
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-09-27 05:40:12 +0200
commita58f37720d389fe921b35daf45afb1c4e2c02274 (patch)
tree77d12d895d0c4079bec2f3194806d5bf792ca224 /test
parentccbedd55a64449f00102f1b17cd6b75944f3a931 (diff)
downloadandroid-node-v8-a58f37720d389fe921b35daf45afb1c4e2c02274.tar.gz
android-node-v8-a58f37720d389fe921b35daf45afb1c4e2c02274.tar.bz2
android-node-v8-a58f37720d389fe921b35daf45afb1c4e2c02274.zip
test: add dns.onlookupall() to increase coverage
Added test that callback should be called when error occurs in dns.lookupall(). PR-URL: https://github.com/nodejs/node/pull/22985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r--test/internet/test-dns-lookup.js18
1 files changed, 17 insertions, 1 deletions
diff --git a/test/internet/test-dns-lookup.js b/test/internet/test-dns-lookup.js
index b84f80735f..df5ccf99a5 100644
--- a/test/internet/test-dns-lookup.js
+++ b/test/internet/test-dns-lookup.js
@@ -1,7 +1,9 @@
'use strict';
require('../common');
-const dnsPromises = require('dns').promises;
+const common = require('../common');
+const dns = require('dns');
+const dnsPromises = dns.promises;
const { addresses } = require('../common/internet');
const assert = require('assert');
@@ -28,3 +30,17 @@ assert.rejects(
message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
}
);
+
+dns.lookup(addresses.INVALID_HOST, {
+ hints: 0,
+ family: 0,
+ all: true
+}, common.mustCall((error) => {
+ assert.strictEqual(error.code, 'ENOTFOUND');
+ assert.strictEqual(
+ error.message,
+ `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
+ );
+ assert.strictEqual(error.syscall, 'getaddrinfo');
+ assert.strictEqual(error.hostname, addresses.INVALID_HOST);
+}));