diff options
author | Julien Gilli <jgilli@netflix.com> | 2018-10-08 17:14:15 -0700 |
---|---|---|
committer | Julien Gilli <jgilli@netflix.com> | 2018-10-09 09:36:08 -0700 |
commit | a3e604e9a3f4e3da137ca4874107d89fa596611a (patch) | |
tree | d9674c961bf5ac86192302fb0b19823824ef8e02 /test | |
parent | c65a523597ccdf2b3544244679dae581040cf52f (diff) | |
download | android-node-v8-a3e604e9a3f4e3da137ca4874107d89fa596611a.tar.gz android-node-v8-a3e604e9a3f4e3da137ca4874107d89fa596611a.tar.bz2 android-node-v8-a3e604e9a3f4e3da137ca4874107d89fa596611a.zip |
test: remove obsolete domain test
test-microtask-queue-integration-domain.js tests that the behavior of
another test, test-microtask-queue-integration.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.
PR-URL: https://github.com/nodejs/node/pull/23342
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-microtask-queue-integration-domain.js | 70 |
1 files changed, 0 insertions, 70 deletions
diff --git a/test/parallel/test-microtask-queue-integration-domain.js b/test/parallel/test-microtask-queue-integration-domain.js deleted file mode 100644 index 98da703ee5..0000000000 --- a/test/parallel/test-microtask-queue-integration-domain.js +++ /dev/null @@ -1,70 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -'use strict'; -require('../common'); -const assert = require('assert'); - -// Requiring the domain module here changes the function that is used by node to -// call process.nextTick's callbacks to a variant that specifically handles -// domains. We want to test this specific variant in this test, and so even if -// the domain module is not used, this require call is needed and must not be -// removed. -require('domain'); - -const implementations = [ - function(fn) { - Promise.resolve().then(fn); - } -]; - -let expected = 0; -let done = 0; - -process.on('exit', function() { - assert.strictEqual(done, expected); -}); - -function test(scheduleMicrotask) { - let nextTickCalled = false; - expected++; - - scheduleMicrotask(function() { - process.nextTick(function() { - nextTickCalled = true; - }); - - setTimeout(function() { - assert(nextTickCalled); - done++; - }, 0); - }); -} - -// first tick case -implementations.forEach(test); - -// tick callback case -setTimeout(function() { - implementations.forEach(function(impl) { - process.nextTick(test.bind(null, impl)); - }); -}, 0); |