diff options
author | Rich Trott <rtrott@gmail.com> | 2016-04-01 06:38:00 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2016-04-03 22:11:33 -0700 |
commit | 8d96300c22b81b5d3cd966185b9b130411b5609f (patch) | |
tree | 60f32802b049f8f4bb81de1e9f05eec24902a211 /test | |
parent | f739a1222f06593c107eb737119a6fce18f91c51 (diff) | |
download | android-node-v8-8d96300c22b81b5d3cd966185b9b130411b5609f.tar.gz android-node-v8-8d96300c22b81b5d3cd966185b9b130411b5609f.tar.bz2 android-node-v8-8d96300c22b81b5d3cd966185b9b130411b5609f.zip |
test: fix test-dns.js flakiness
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.
PR-URL: https://github.com/nodejs/node/pull/5996
Fixes: https://github.com/nodejs/node/issues/5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-dns.js | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test/parallel/test-dns.js b/test/parallel/test-dns.js index d473ae8d95..d9ee2c4d85 100644 --- a/test/parallel/test-dns.js +++ b/test/parallel/test-dns.js @@ -1,8 +1,8 @@ 'use strict'; require('../common'); -var assert = require('assert'); +const assert = require('assert'); -var dns = require('dns'); +const dns = require('dns'); var existing = dns.getServers(); assert(existing.length); @@ -121,27 +121,27 @@ assert.doesNotThrow(function() { }); assert.doesNotThrow(function() { - dns.lookup('www.google.com', { + dns.lookup('', { family: 4, hints: 0 }, noop); }); assert.doesNotThrow(function() { - dns.lookup('www.google.com', { + dns.lookup('', { family: 6, hints: dns.ADDRCONFIG }, noop); }); assert.doesNotThrow(function() { - dns.lookup('www.google.com', { + dns.lookup('', { hints: dns.V4MAPPED }, noop); }); assert.doesNotThrow(function() { - dns.lookup('www.google.com', { + dns.lookup('', { hints: dns.ADDRCONFIG | dns.V4MAPPED }, noop); }); |