diff options
author | cjihrig <cjihrig@gmail.com> | 2018-08-23 09:28:41 -0400 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2018-08-30 09:08:44 -0400 |
commit | 8b0c482647004667ac9688f72264b9efca36b699 (patch) | |
tree | 7888478e95eed7b6160d46c0db23c9e891d3951b /test | |
parent | 60465700ed055640e737ca3a53e16465dfec00d6 (diff) | |
download | android-node-v8-8b0c482647004667ac9688f72264b9efca36b699.tar.gz android-node-v8-8b0c482647004667ac9688f72264b9efca36b699.tar.bz2 android-node-v8-8b0c482647004667ac9688f72264b9efca36b699.zip |
dns: make process.binding('cares_wrap') internal
PR-URL: https://github.com/nodejs/node/pull/22474
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test')
-rw-r--r-- | test/internet/test-dns.js | 4 | ||||
-rw-r--r-- | test/parallel/test-dns-lookup.js | 5 | ||||
-rw-r--r-- | test/parallel/test-tls-canonical-ip.js | 4 | ||||
-rw-r--r-- | test/sequential/test-async-wrap-getasyncid.js | 2 |
4 files changed, 9 insertions, 6 deletions
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index 4608713927..5c53781fde 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -1,3 +1,4 @@ +// Flags: --expose-internals // Copyright Joyent, Inc. and other Node contributors. // // Permission is hereby granted, free of charge, to any person obtaining a @@ -22,6 +23,7 @@ 'use strict'; const common = require('../common'); const { addresses } = require('../common/internet'); +const { internalBinding } = require('internal/test/binding'); const assert = require('assert'); const dns = require('dns'); const net = require('net'); @@ -674,7 +676,7 @@ let getaddrinfoCallbackCalled = false; console.log(`looking up ${addresses.INET4_HOST}..`); -const cares = process.binding('cares_wrap'); +const cares = internalBinding('cares_wrap'); const req = new cares.GetAddrInfoReqWrap(); cares.getaddrinfo(req, addresses.INET4_HOST, 4, /* hints */ 0, /* verbatim */ true); diff --git a/test/parallel/test-dns-lookup.js b/test/parallel/test-dns-lookup.js index b45393718a..b20d403d37 100644 --- a/test/parallel/test-dns-lookup.js +++ b/test/parallel/test-dns-lookup.js @@ -3,12 +3,11 @@ const common = require('../common'); const { addresses } = require('../common/internet'); const assert = require('assert'); -const cares = process.binding('cares_wrap'); +const { internalBinding } = require('internal/test/binding'); +const cares = internalBinding('cares_wrap'); const dns = require('dns'); const dnsPromises = dns.promises; -const { internalBinding } = require('internal/test/binding'); - // Stub `getaddrinfo` to *always* error. cares.getaddrinfo = () => internalBinding('uv').UV_ENOENT; diff --git a/test/parallel/test-tls-canonical-ip.js b/test/parallel/test-tls-canonical-ip.js index 408948119c..f5a4aab17a 100644 --- a/test/parallel/test-tls-canonical-ip.js +++ b/test/parallel/test-tls-canonical-ip.js @@ -1,3 +1,4 @@ +// Flags: --expose-internals 'use strict'; require('../common'); @@ -6,7 +7,8 @@ require('../common'); // of a TLS certificate const assert = require('assert'); -const { canonicalizeIP } = process.binding('cares_wrap'); +const { internalBinding } = require('internal/test/binding'); +const { canonicalizeIP } = internalBinding('cares_wrap'); assert.strictEqual(canonicalizeIP('127.0.0.1'), '127.0.0.1'); assert.strictEqual(canonicalizeIP('10.1.0.1'), '10.1.0.1'); diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js index 6e17b65793..866970c0d6 100644 --- a/test/sequential/test-async-wrap-getasyncid.js +++ b/test/sequential/test-async-wrap-getasyncid.js @@ -69,7 +69,7 @@ function testInitialized(req, ctor_name) { { - const cares = process.binding('cares_wrap'); + const cares = internalBinding('cares_wrap'); const dns = require('dns'); testUninitialized(new cares.GetAddrInfoReqWrap(), 'GetAddrInfoReqWrap'); |