diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-05 17:06:32 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-06-09 19:51:30 +0200 |
commit | 890223dede339622e7e66e8629805f7904840870 (patch) | |
tree | 96b2150280c3d3fb3ef159715a7b036d16f78a10 /test | |
parent | 0c1fd2069376cb2b3796ea83dc131a0a1def132d (diff) | |
download | android-node-v8-890223dede339622e7e66e8629805f7904840870.tar.gz android-node-v8-890223dede339622e7e66e8629805f7904840870.tar.bz2 android-node-v8-890223dede339622e7e66e8629805f7904840870.zip |
src: expose DOMException to internalBinding('message') for testing
Instead of using a hack to get it in the test.
PR-URL: https://github.com/nodejs/node/pull/28072
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/wpt/test-url.js | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/test/wpt/test-url.js b/test/wpt/test-url.js index 4b909988dd..5d5240ce18 100644 --- a/test/wpt/test-url.js +++ b/test/wpt/test-url.js @@ -3,29 +3,16 @@ // Flags: --expose-internals require('../common'); -const assert = require('assert'); const { WPTRunner } = require('../common/wpt'); - +const { internalBinding } = require('internal/test/binding'); +const { DOMException } = internalBinding('messaging'); const runner = new WPTRunner('url'); // Copy global descriptors from the global object runner.copyGlobalsFromObject(global, ['URL', 'URLSearchParams']); // Needed by urlsearchparams-constructor.any.js -let DOMException; runner.defineGlobal('DOMException', { get() { - // A 'hack' to get the DOMException constructor since we don't have it - // on the global object. - if (DOMException === undefined) { - const port = new (require('worker_threads').MessagePort)(); - const ab = new ArrayBuffer(1); - try { - port.postMessage(ab, [ab, ab]); - } catch (err) { - DOMException = err.constructor; - } - assert.strictEqual(DOMException.name, 'DOMException'); - } return DOMException; } }); |