diff options
| author | Benjamin Ki <me@benjaminki.com> | 2019-05-04 21:28:32 -0400 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-05-13 14:26:40 -0700 |
| commit | 7294897c77d1e5612efe49aad9f84809ba8d1592 (patch) | |
| tree | 54cc6f904dec0dcf407e384ce80eb4f6b2896f60 /test | |
| parent | 402a793012b934447276eacb5052efe5cf041cc2 (diff) | |
| download | android-node-v8-7294897c77d1e5612efe49aad9f84809ba8d1592.tar.gz android-node-v8-7294897c77d1e5612efe49aad9f84809ba8d1592.tar.bz2 android-node-v8-7294897c77d1e5612efe49aad9f84809ba8d1592.zip | |
test: use common.PORT instead of an extraneous variable
This test is not parallelized and so we can use the test commons PORT
variable.
Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162
PR-URL: https://github.com/nodejs/node/pull/27565
Fixes: https://github.com/nodejs/node/issues/27341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
| -rw-r--r-- | test/internet/test-dgram-connect.js | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/test/internet/test-dgram-connect.js b/test/internet/test-dgram-connect.js index 785181cee6..47a12c7890 100644 --- a/test/internet/test-dgram-connect.js +++ b/test/internet/test-dgram-connect.js @@ -5,17 +5,15 @@ const { addresses } = require('../common/internet'); const assert = require('assert'); const dgram = require('dgram'); -const PORT = 12345; - const client = dgram.createSocket('udp4'); -client.connect(PORT, addresses.INVALID_HOST, common.mustCall((err) => { +client.connect(common.PORT, addresses.INVALID_HOST, common.mustCall((err) => { assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN'); client.once('error', common.mustCall((err) => { assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN'); client.once('connect', common.mustCall(() => client.close())); - client.connect(PORT); + client.connect(common.PORT); })); - client.connect(PORT, addresses.INVALID_HOST); + client.connect(common.PORT, addresses.INVALID_HOST); })); |