diff options
| author | Rainer Poisel <rainer.poisel@gmail.com> | 2019-08-13 00:12:16 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-08-15 22:58:40 -0700 |
| commit | 71b5ce58854c196e2cdc5abdecd386d7135b9824 (patch) | |
| tree | 06232f758cacdd81ca0f512fe1398638f0733707 /test | |
| parent | 1173199e81aba723d57c4c49c8078b91be333096 (diff) | |
| download | android-node-v8-71b5ce58854c196e2cdc5abdecd386d7135b9824.tar.gz android-node-v8-71b5ce58854c196e2cdc5abdecd386d7135b9824.tar.bz2 android-node-v8-71b5ce58854c196e2cdc5abdecd386d7135b9824.zip | |
test: make exported method static
The exported method can be static as it will never be called directly.
PR-URL: https://github.com/nodejs/node/pull/29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/addons/hello-world/binding.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/hello-world/binding.cc b/test/addons/hello-world/binding.cc index 81bcbc29c7..f2d26b53e9 100644 --- a/test/addons/hello-world/binding.cc +++ b/test/addons/hello-world/binding.cc @@ -1,7 +1,7 @@ #include <node.h> #include <v8.h> -void Method(const v8::FunctionCallbackInfo<v8::Value>& args) { +static void Method(const v8::FunctionCallbackInfo<v8::Value>& args) { v8::Isolate* isolate = args.GetIsolate(); args.GetReturnValue().Set(v8::String::NewFromUtf8( isolate, "world", v8::NewStringType::kNormal).ToLocalChecked()); |