diff options
author | Rich Trott <rtrott@gmail.com> | 2017-02-09 21:29:56 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2017-02-12 23:54:31 -0800 |
commit | 6dd979e67ce43beae56b06ed703ad8bd6a8f4370 (patch) | |
tree | 6edffd8ea08a5d14a442a9c6a0e5f92c851e4986 /test | |
parent | dd1cf8bb37d411082adebce4ba5db5576cba8bf6 (diff) | |
download | android-node-v8-6dd979e67ce43beae56b06ed703ad8bd6a8f4370.tar.gz android-node-v8-6dd979e67ce43beae56b06ed703ad8bd6a8f4370.tar.bz2 android-node-v8-6dd979e67ce43beae56b06ed703ad8bd6a8f4370.zip |
test: refactor test-readline-keys
* replace `util._extend()` with `Object.assign()`
* extract repeated map function to a single instance
* remove unneeded truthiness-check ternary on Objects
PR-URL: https://github.com/nodejs/node/pull/11281
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-readline-keys.js | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/test/parallel/test-readline-keys.js b/test/parallel/test-readline-keys.js index 39c8aa0668..1b05b06f58 100644 --- a/test/parallel/test-readline-keys.js +++ b/test/parallel/test-readline-keys.js @@ -3,7 +3,6 @@ const common = require('../common'); const PassThrough = require('stream').PassThrough; const assert = require('assert'); const inherits = require('util').inherits; -const extend = require('util')._extend; const Interface = require('readline').Interface; @@ -12,6 +11,10 @@ function FakeInput() { } inherits(FakeInput, PassThrough); +function extend(k) { + return Object.assign({ ctrl: false, meta: false, shift: false }, k); +} + const fi = new FakeInput(); const fo = new FakeInput(); @@ -32,9 +35,7 @@ function addTest(sequences, expectedKeys) { expectedKeys = [ expectedKeys ]; } - expectedKeys = expectedKeys.map((k) => { - return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k; - }); + expectedKeys = expectedKeys.map(extend); keys = []; @@ -65,9 +66,7 @@ const addKeyIntervalTest = (sequences, expectedKeys, interval = 550, expectedKeys = [ expectedKeys ]; } - expectedKeys = expectedKeys.map((k) => { - return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k; - }); + expectedKeys = expectedKeys.map(extend); const keys = []; fi.on('keypress', (s, k) => keys.push(k)); |