aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-05-07 09:28:12 -0700
committerRich Trott <rtrott@gmail.com>2017-05-11 07:49:02 -0700
commit631cb42b4e2e067d82bd0c11b9317caf3b47e14a (patch)
treeff0621cd6fab495385e553c9e4b24b5e029e4b55 /test
parent654afa2c195a68ce4959fe7f918d70da99d7ba05 (diff)
downloadandroid-node-v8-631cb42b4e2e067d82bd0c11b9317caf3b47e14a.tar.gz
android-node-v8-631cb42b4e2e067d82bd0c11b9317caf3b47e14a.tar.bz2
android-node-v8-631cb42b4e2e067d82bd0c11b9317caf3b47e14a.zip
test: favor deepStrictEqual over deepEqual
test-http-mutable-headers uses assert.deepEqual() in three places but appears to only needs it in two of them. Replace one with assert.deepStrictEqual() and remove linting exception. PR-URL: https://github.com/nodejs/node/pull/12883 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-http-mutable-headers.js11
1 files changed, 4 insertions, 7 deletions
diff --git a/test/parallel/test-http-mutable-headers.js b/test/parallel/test-http-mutable-headers.js
index adaca917c0..63f4b4cad2 100644
--- a/test/parallel/test-http-mutable-headers.js
+++ b/test/parallel/test-http-mutable-headers.js
@@ -73,17 +73,14 @@ const s = http.createServer(common.mustCall((req, res) => {
assert.strictEqual(res.getHeader('x-test-header2'), 'testing');
const headersCopy = res.getHeaders();
- assert.strictEqual(Object.getPrototypeOf(headersCopy), null);
- // eslint-disable-next-line no-restricted-properties
- assert.deepEqual(headersCopy, {
+ const expected = {
'x-test-header': 'testing',
'x-test-header2': 'testing',
'set-cookie': cookies,
'x-test-array-header': arrayValues
- });
- // eslint-disable-next-line no-restricted-properties
- assert.deepEqual(headersCopy['set-cookie'], cookies);
- assert.strictEqual(headersCopy['x-test-array-header'], arrayValues);
+ };
+ Object.setPrototypeOf(expected, null);
+ assert.deepStrictEqual(headersCopy, expected);
assert.deepStrictEqual(res.getHeaderNames(),
['x-test-header', 'x-test-header2',