diff options
author | Rich Trott <rtrott@gmail.com> | 2019-02-15 22:07:58 -0800 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-02-18 09:19:56 +0100 |
commit | 584dc4893c8c5be0a3c39c0179809e60b774cb95 (patch) | |
tree | 047fd29e350fd644a303b2faa411746a2e2ba5c7 /test | |
parent | 85b95cc6a3d017c58a0e15efa2c4406b34bd4611 (diff) | |
download | android-node-v8-584dc4893c8c5be0a3c39c0179809e60b774cb95.tar.gz android-node-v8-584dc4893c8c5be0a3c39c0179809e60b774cb95.tar.bz2 android-node-v8-584dc4893c8c5be0a3c39c0179809e60b774cb95.zip |
test: simplify test-worker-syntax-error
Remove extraneous code from test-worker-syntax-error. Because the worker
is called with `eval: true`, there is no need to set an environment
variable indicating whether the worker has started and so on. The test
file is only ever executed by the main thread.
PR-URL: https://github.com/nodejs/node/pull/26144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-worker-syntax-error.js | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/test/parallel/test-worker-syntax-error.js b/test/parallel/test-worker-syntax-error.js index 5c91eb2d25..1c1fbf1c1a 100644 --- a/test/parallel/test-worker-syntax-error.js +++ b/test/parallel/test-worker-syntax-error.js @@ -3,15 +3,9 @@ const common = require('../common'); const assert = require('assert'); const { Worker } = require('worker_threads'); -// Do not use isMainThread so that this test itself can be run inside a Worker. -if (!process.env.HAS_STARTED_WORKER) { - process.env.HAS_STARTED_WORKER = 1; - const w = new Worker('abc)', { eval: true }); - w.on('message', common.mustNotCall()); - w.on('error', common.mustCall((err) => { - assert.strictEqual(err.constructor, SyntaxError); - assert(/SyntaxError/.test(err)); - })); -} else { - throw new Error('foo'); -} +const w = new Worker('abc)', { eval: true }); +w.on('message', common.mustNotCall()); +w.on('error', common.mustCall((err) => { + assert.strictEqual(err.constructor, SyntaxError); + assert(/SyntaxError/.test(err)); +})); |