diff options
| author | Jeremy Apthorp <nornagon@nornagon.net> | 2019-10-25 14:52:13 -0700 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-11-19 16:03:55 +0100 |
| commit | 4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e (patch) | |
| tree | 202bedfd5c4c2e6430c2c8e37921a30d52b707db /test | |
| parent | 7cecac669f05f36016c684dcee381cf21ab188d2 (diff) | |
| download | android-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.tar.gz android-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.tar.bz2 android-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.zip | |
src: add file name to 'Module did not self-register' error
PR-URL: https://github.com/nodejs/node/pull/30125
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'test')
| -rw-r--r-- | test/addons/dlopen-ping-pong/test-worker.js | 3 | ||||
| -rw-r--r-- | test/addons/dlopen-ping-pong/test.js | 2 | ||||
| -rw-r--r-- | test/addons/not-a-binding/test.js | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/test/addons/dlopen-ping-pong/test-worker.js b/test/addons/dlopen-ping-pong/test-worker.js index feba6aa5eb..d24bd2df80 100644 --- a/test/addons/dlopen-ping-pong/test-worker.js +++ b/test/addons/dlopen-ping-pong/test-worker.js @@ -16,5 +16,6 @@ require(bindingPath); new Worker(`require(${JSON.stringify(bindingPath)})`, { eval: true }) .on('error', common.mustCall((err) => { assert.strictEqual(err.constructor, Error); - assert.strictEqual(err.message, 'Module did not self-register.'); + assert.strictEqual(err.message, + `Module did not self-register: '${bindingPath}'.`); })); diff --git a/test/addons/dlopen-ping-pong/test.js b/test/addons/dlopen-ping-pong/test.js index c5b8c16493..c3461d8bd2 100644 --- a/test/addons/dlopen-ping-pong/test.js +++ b/test/addons/dlopen-ping-pong/test.js @@ -19,5 +19,5 @@ assert.strictEqual(module.exports.ping(), 'pong'); // Check that after the addon is loaded with // process.dlopen() a require() call fails. console.log('require:', `./build/${common.buildType}/binding`); -const re = /^Error: Module did not self-register\.$/; +const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/; assert.throws(() => require(`./build/${common.buildType}/binding`), re); diff --git a/test/addons/not-a-binding/test.js b/test/addons/not-a-binding/test.js index a0ce2d0629..4b4e7150eb 100644 --- a/test/addons/not-a-binding/test.js +++ b/test/addons/not-a-binding/test.js @@ -2,5 +2,5 @@ const common = require('../../common'); const assert = require('assert'); -const re = /^Error: Module did not self-register\.$/; +const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/; assert.throws(() => require(`./build/${common.buildType}/binding`), re); |