summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorKelvin Jin <kelvinjin@google.com>2018-12-10 15:50:22 -0800
committerRich Trott <rtrott@gmail.com>2018-12-13 20:48:45 -0800
commit49f1db47e2bb0fa4f2a53f4244639502688a291b (patch)
tree49da8507e80bd871ca9b87d171a5848f743f716c /test
parent1c52dccc54da29fa787bafdc44986f1fadd1273f (diff)
downloadandroid-node-v8-49f1db47e2bb0fa4f2a53f4244639502688a291b.tar.gz
android-node-v8-49f1db47e2bb0fa4f2a53f4244639502688a291b.tar.bz2
android-node-v8-49f1db47e2bb0fa4f2a53f4244639502688a291b.zip
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: https://github.com/nodejs/node/pull/24949 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-inspector-tracing-domain.js2
-rw-r--r--test/parallel/test-trace-events-dynamic-enable.js4
2 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-inspector-tracing-domain.js b/test/parallel/test-inspector-tracing-domain.js
index ecf15c5be9..9d3d33d94d 100644
--- a/test/parallel/test-inspector-tracing-domain.js
+++ b/test/parallel/test-inspector-tracing-domain.js
@@ -60,7 +60,7 @@ async function test() {
await generateTrace();
JSON.stringify(await post('NodeTracing.stop', { traceConfig }));
session.disconnect();
- assert(traceNotification.data.value.length > 0);
+ assert(traceNotification.params.value.length > 0);
assert(tracingComplete);
clearInterval(interval);
console.log('Success');
diff --git a/test/parallel/test-trace-events-dynamic-enable.js b/test/parallel/test-trace-events-dynamic-enable.js
index 645dcb2764..b10152370f 100644
--- a/test/parallel/test-trace-events-dynamic-enable.js
+++ b/test/parallel/test-trace-events-dynamic-enable.js
@@ -28,8 +28,8 @@ async function test() {
const events = [];
let tracingComplete = false;
session.on('NodeTracing.dataCollected', (n) => {
- assert.ok(n && n.data && n.data.value);
- events.push(...n.data.value); // append the events.
+ assert.ok(n && n.params && n.params.value);
+ events.push(...n.params.value); // append the events.
});
session.on('NodeTracing.tracingComplete', () => tracingComplete = true);