summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2018-06-19 01:02:57 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2018-06-27 21:11:31 +0800
commit4750ce26f2e6079b5fee92bdee5356c279171d22 (patch)
tree1a53ec9b0b18b658109b453b236f053b0b457850 /test
parent7c452845b8d44287f5db96a7f19e7d395e1899ab (diff)
downloadandroid-node-v8-4750ce26f2e6079b5fee92bdee5356c279171d22.tar.gz
android-node-v8-4750ce26f2e6079b5fee92bdee5356c279171d22.tar.bz2
android-node-v8-4750ce26f2e6079b5fee92bdee5356c279171d22.zip
build: speed up startup with V8 code cache
This patch speeds up the startup time and reduce the startup memory footprint by using V8 code cache when comiling builtin modules. The current approach is demonstrated in the `with-code-cache` Makefile target (no corresponding Windows target at the moment). 1. Build the binary normally (`src/node_code_cache_stub.cc` is used), by now `internalBinding('code_cache')` is an empty object 2. Run `tools/generate_code_cache.js` with the binary, which generates the code caches by reading source code of builtin modules off source code exposed by `require('internal/bootstrap/cache').builtinSource` and then generate a C++ file containing static char arrays of the code cache, using a format similar to `node_javascript.cc` 3. Run `configure` with the `--code-cache-path` option so that the newly generated C++ file will be used when compiling the new binary. The generated C++ file will put the cache into the `internalBinding('code_cache')` object with the module ids as keys 4. The new binary tries to read the code cache from `internalBinding('code_cache')` and use it to compile builtin modules. If the cache is used, it will put the id into `require('internal/bootstrap/cache').compiledWithCache` for bookkeeping, otherwise the id will be pushed into `require('internal/bootstrap/cache').compiledWithoutCache` This patch also added tests that verify the code cache is generated and used when compiling builtin modules. The binary with code cache: - Is ~1MB bigger than the binary without code cahe - Consumes ~1MB less memory during start up - Starts up about 60% faster PR-URL: https://github.com/nodejs/node/pull/21405 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'test')
-rw-r--r--test/code-cache/code-cache.status21
-rw-r--r--test/code-cache/test-code-cache.js42
-rw-r--r--test/code-cache/testcfg.py6
3 files changed, 69 insertions, 0 deletions
diff --git a/test/code-cache/code-cache.status b/test/code-cache/code-cache.status
new file mode 100644
index 0000000000..26eb66ea2d
--- /dev/null
+++ b/test/code-cache/code-cache.status
@@ -0,0 +1,21 @@
+prefix code-cache
+
+# To mark a test as flaky, list the test name in the appropriate section
+# below, without ".js", followed by ": PASS,FLAKY". Example:
+# sample-test : PASS,FLAKY
+
+[true] # This section applies to all platforms
+
+[$system==win32]
+
+[$system==linux]
+
+[$system==macos]
+
+[$arch==arm || $arch==arm64]
+
+[$system==solaris] # Also applies to SmartOS
+
+[$system==freebsd]
+
+[$system==aix]
diff --git a/test/code-cache/test-code-cache.js b/test/code-cache/test-code-cache.js
new file mode 100644
index 0000000000..a437834301
--- /dev/null
+++ b/test/code-cache/test-code-cache.js
@@ -0,0 +1,42 @@
+'use strict';
+
+// Flags: --expose-internals
+// This test verifies that the binary is compiled with code cache and the
+// cache is used when built in modules are compiled.
+
+require('../common');
+const assert = require('assert');
+const {
+ types: {
+ isUint8Array
+ }
+} = require('util');
+const {
+ builtinSource,
+ codeCache,
+ cannotUseCache,
+ compiledWithCache,
+ compiledWithoutCache
+} = require('internal/bootstrap/cache');
+
+assert.strictEqual(
+ typeof process.config.variables.node_code_cache_path,
+ 'string'
+);
+
+assert.deepStrictEqual(compiledWithoutCache, []);
+
+const loadedModules = process.moduleLoadList
+ .filter((m) => m.startsWith('NativeModule'))
+ .map((m) => m.replace('NativeModule ', ''));
+
+for (const key of loadedModules) {
+ assert(compiledWithCache.includes(key),
+ `"${key}" should've been compiled with code cache`);
+}
+
+for (const key of Object.keys(builtinSource)) {
+ if (cannotUseCache.includes(key)) continue;
+ assert(isUint8Array(codeCache[key]) && codeCache[key].length > 0,
+ `Code cache for "${key}" should've been generated`);
+}
diff --git a/test/code-cache/testcfg.py b/test/code-cache/testcfg.py
new file mode 100644
index 0000000000..0e0035dfed
--- /dev/null
+++ b/test/code-cache/testcfg.py
@@ -0,0 +1,6 @@
+import sys, os
+sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
+import testpy
+
+def GetConfiguration(context, root):
+ return testpy.ParallelTestConfiguration(context, root, 'code-cache')