diff options
author | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2018-04-25 12:45:34 -0400 |
---|---|---|
committer | Ujjwal Sharma <usharma1998@gmail.com> | 2018-05-10 22:19:27 +0530 |
commit | 46d335c380510fda68e62a4cdafa58e7e7b230a1 (patch) | |
tree | 6bf18decea35ca947eb61174de00e5b6335fbce5 /test | |
parent | d9425733931d86b41cbe0cb7f7f9940af4cbe8a5 (diff) | |
download | android-node-v8-46d335c380510fda68e62a4cdafa58e7e7b230a1.tar.gz android-node-v8-46d335c380510fda68e62a4cdafa58e7e7b230a1.tar.bz2 android-node-v8-46d335c380510fda68e62a4cdafa58e7e7b230a1.zip |
timers: make timer.refresh() a public API
Originally added in
bb5575aa75fd3071724d5eccde39a3041e1af57a
discussions such as
https://github.com/nodejs/node/issues/20261
show the usefulness of this API to the Node.js ecosystem.
PR-URL: https://github.com/nodejs/node/pull/20298
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-timers-refresh.js | 25 |
1 files changed, 21 insertions, 4 deletions
diff --git a/test/parallel/test-timers-refresh.js b/test/parallel/test-timers-refresh.js index 25a22329c0..2c47be8d8d 100644 --- a/test/parallel/test-timers-refresh.js +++ b/test/parallel/test-timers-refresh.js @@ -5,7 +5,7 @@ const common = require('../common'); const { strictEqual } = require('assert'); -const { setUnrefTimeout, refreshFnSymbol } = require('internal/timers'); +const { setUnrefTimeout } = require('internal/timers'); // Schedule the unrefed cases first so that the later case keeps the event loop // active. @@ -27,7 +27,7 @@ const { setUnrefTimeout, refreshFnSymbol } = require('internal/timers'); strictEqual(called, false, 'unref()\'d timer returned before check'); }), 1); - timer[refreshFnSymbol](); + strictEqual(timer.refresh(), timer); } // unref pooled timer @@ -41,7 +41,7 @@ const { setUnrefTimeout, refreshFnSymbol } = require('internal/timers'); strictEqual(called, false, 'unref pooled timer returned before check'); }), 1); - timer[refreshFnSymbol](); + strictEqual(timer.refresh(), timer); } // regular timer @@ -55,5 +55,22 @@ const { setUnrefTimeout, refreshFnSymbol } = require('internal/timers'); strictEqual(called, false, 'pooled timer returned before check'); }), 1); - timer[refreshFnSymbol](); + strictEqual(timer.refresh(), timer); +} + +// interval +{ + let called = 0; + const timer = setInterval(common.mustCall(() => { + called += 1; + if (called === 2) { + clearInterval(timer); + } + }, 2), 1); + + setTimeout(common.mustCall(() => { + strictEqual(called, 0, 'pooled timer returned before check'); + }), 1); + + strictEqual(timer.refresh(), timer); } |