crypto: improve error messages

Introduce a new MACRO to check if the data is a String object and
update existing MACROs to include the actual object description to
be printed in case of an error.

PR-URL: https://github.com/nodejs/node/pull/3100
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 35 insertions, 0 deletions

diff --git a/test/parallel/test-tls-basic-validations.js b/test/parallel/test-tls-basic-validations.js
new file mode 100644
index 0000000000..a741f3b49c
--- /dev/null
+++ b/test/parallel/test-tls-basic-validations.js
@@ -0,0 +1,35 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const tls = require('tls');
+
+assert.throws(() => tls.createSecureContext({ciphers: 1}),
+              /TypeError: Ciphers must be a string/);
+
+assert.throws(() => tls.createServer({ciphers: 1}),
+              /TypeError: Ciphers must be a string/);
+
+assert.throws(() => tls.createSecureContext({key: 'dummykey', passphrase: 1}),
+              /TypeError: Pass phrase must be a string/);
+
+assert.throws(() => tls.createServer({key: 'dummykey', passphrase: 1}),
+              /TypeError: Pass phrase must be a string/);
+
+assert.throws(() => tls.createServer({ecdhCurve: 1}),
+              /TypeError: ECDH curve name must be a string/);
+
+assert.throws(() => tls.createServer({handshakeTimeout: 'abcd'}),
+              /TypeError: handshakeTimeout must be a number/);
+
+assert.throws(() => tls.createServer({sessionTimeout: 'abcd'}),
+              /TypeError: Session timeout must be a 32-bit integer/);
+
+assert.throws(() => tls.createServer({ticketKeys: 'abcd'}),
+              /TypeError: Ticket keys must be a buffer/);
+
+assert.throws(() => tls.createServer({ticketKeys: new Buffer(0)}),
+              /TypeError: Ticket keys length must be 48 bytes/);
+
+assert.throws(() => tls.createSecurePair({}),
+              /Error: First argument must be a tls module SecureContext/);