diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-11-17 00:18:55 +0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-11-18 08:40:23 -0800 |
commit | 413fcada8fb8289ec81010fe66a975e046d15ece (patch) | |
tree | e28dec5564dc7353b9a1a238da102d72e99c86e4 /test | |
parent | ea655191d3df2b5ae62a66e5071cd151b1919c92 (diff) | |
download | android-node-v8-413fcada8fb8289ec81010fe66a975e046d15ece.tar.gz android-node-v8-413fcada8fb8289ec81010fe66a975e046d15ece.tar.bz2 android-node-v8-413fcada8fb8289ec81010fe66a975e046d15ece.zip |
stream: do not use crypto.DEFAULT_ENCODING in lazy_transform.js
The default encoding can be retrieved via
`require('internal/crypto/util').getDefaultEncoding` instead of
the deprecated crypto.DEFAULT_ENCODING which triggers a warning.
Background:
The require chain goes like this:
```
internal/streams/lazy_transform.js
-> crypto.js
-> internal/crypto/cipher.js (uses LazyTransform in the global scope)
-> internal/streams/lazy_transform.js
```
So when `internal/streams/lazy_transform.js` is required before
`lib/crypto.js`, we have a circular dependency and since
`internal/crypto/cipher.js` uses destructuring to use LazyTransform
we will get an error. And it can also trigger a warning if
lazy_transform.js is the first file that touches
crypto.DEFAULT_ENCODING.
PR-URL: https://github.com/nodejs/node/pull/24396
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions