diff options
author | Rich Trott <rtrott@gmail.com> | 2019-08-27 14:55:40 -0700 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-08-28 06:04:50 +0200 |
commit | 3ae6f5e1169f423e71036d1bbd62f2c26b136914 (patch) | |
tree | 6a0e03f4e3407a229043148e6789a73efae1cf91 /test | |
parent | 34961c7b5fe8b2cf1722668666a7adcce3ab419c (diff) | |
download | android-node-v8-3ae6f5e1169f423e71036d1bbd62f2c26b136914.tar.gz android-node-v8-3ae6f5e1169f423e71036d1bbd62f2c26b136914.tar.bz2 android-node-v8-3ae6f5e1169f423e71036d1bbd62f2c26b136914.zip |
test: fix flaky test-http-server-keepalive-req-gc
Use `server` to keep the event loop open until the `ongc` listener runs.
PR-URL: https://github.com/nodejs/node/pull/29347
Fixes: https://github.com/nodejs/node/issues/29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-http-server-keepalive-req-gc.js | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index aa4bf1a3de..77defb5154 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -16,7 +16,7 @@ if (common.isWindows) { let client; const server = createServer(common.mustCall((req, res) => { - onGC(req, { ongc: common.mustCall() }); + onGC(req, { ongc: common.mustCall(() => { server.close(); }) }); req.resume(); req.on('end', common.mustCall(() => { setImmediate(() => { @@ -27,8 +27,6 @@ const server = createServer(common.mustCall((req, res) => { res.end('hello world'); })); -server.unref(); - server.listen(0, common.mustCall(() => { client = connect(server.address().port); |