summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-01-22 14:17:22 -0800
committerRich Trott <rtrott@gmail.com>2019-01-24 14:42:51 -0800
commit35f45ba47b6fe9474a285483044ec27bd0a22896 (patch)
treee5d28bf639c2bddecfb42aef1033c57ef8e9f50f /test
parent0d31293d4aa2c5a8e9de4e7ef446f2566def1908 (diff)
downloadandroid-node-v8-35f45ba47b6fe9474a285483044ec27bd0a22896.tar.gz
android-node-v8-35f45ba47b6fe9474a285483044ec27bd0a22896.tar.bz2
android-node-v8-35f45ba47b6fe9474a285483044ec27bd0a22896.zip
test: remove known_issues/test-cluster-bind-privileged-port
The test was added to check for a bug in macOS Mojave, but it turns out the issue is a macOS feature, not a bug. Refs: https://github.com/nodejs/node/issues/21679#issuecomment-456589386 Fixes: https://github.com/nodejs/node/issues/21679 PR-URL: https://github.com/nodejs/node/pull/25649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'test')
-rw-r--r--test/known_issues/test-cluster-bind-privileged-port.js25
1 files changed, 0 insertions, 25 deletions
diff --git a/test/known_issues/test-cluster-bind-privileged-port.js b/test/known_issues/test-cluster-bind-privileged-port.js
deleted file mode 100644
index 6ada04aa03..0000000000
--- a/test/known_issues/test-cluster-bind-privileged-port.js
+++ /dev/null
@@ -1,25 +0,0 @@
-'use strict';
-const common = require('../common');
-
-// This test should fail on macOS (10.14) due to an issue with privileged ports.
-
-const assert = require('assert');
-const cluster = require('cluster');
-const net = require('net');
-
-if (!common.isOSXMojave)
- assert.fail('Code should fail only on macOS Mojave.');
-
-
-if (cluster.isMaster) {
- cluster.fork().on('exit', common.mustCall((exitCode) => {
- assert.strictEqual(exitCode, 0);
- }));
-} else {
- const s = net.createServer(common.mustNotCall());
- s.listen(42, common.mustNotCall('listen should have failed'));
- s.on('error', common.mustCall((err) => {
- assert.strictEqual(err.code, 'EACCES');
- process.disconnect();
- }));
-}